Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTIFY/LISTEN support? #75

Closed
abevoelker opened this issue Jan 13, 2015 · 4 comments
Closed

NOTIFY/LISTEN support? #75

abevoelker opened this issue Jan 13, 2015 · 4 comments

Comments

@abevoelker
Copy link

Hello, just found this neat project. I currently use queue_classic to process jobs, which doesn't use advisory locks but does use NOTIFY/LISTEN for efficiently picking up new jobs. It looks like que currently uses polling to detect new jobs.

I see there has been some consideration for NOTIFY/LISTEN in #8 and #22 and the "experimental" branch. Just wondering if that's still a feature being considered? Polling works fine for my use case, but I'm just curious. Thanks!

@joevandyk
Copy link
Contributor

There was some work to support listen/notify, but it's incomplete, as far as I know.

Polling is super fast though, and works with connection balancers.

@abevoelker
Copy link
Author

Thanks, yeah I should be perfectly fine just using polling. And yeah I see there is an open issue on queue_classic in regards to issues w/ PgBouncer: QueueClassic/queue_classic#184

@chanks
Copy link
Collaborator

chanks commented Jan 13, 2015

The experimental branch (which replaces single-job polling with a mixture of LISTEN/NOTIFY and batch polling) is functional, though out of date with the changes made to master since that time. The main hurdle that's left, I think, is benchmarking to make sure its design works at scale, and to see what kind of improvement (if any?) it gives over master.

I'd like to get back to it at some point, but since I've been busy and master seems to have been fast enough for everyone's purposes, it just hasn't been a priority.

@chanks chanks closed this as completed Jan 13, 2015
@abevoelker
Copy link
Author

Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants