use now() instead of 'now' #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument 'now' is evaluated when the statement is prepared, not when it is executed. So the timestamp in the insert_job query will be stale after the first execution. Switching it to now() ensures that it is always evaluated when the query is executed. See bgentry/que-go#1 for more details.
|
Not sure what this failed test is about but it doesn't look related: https://travis-ci.org/chanks/que/jobs/46681646 |
|
I saw! Thanks for the blog post, it was very complementary. I actually noticed this issue when I was looking at your port the other day, and tried to reproduce the 'now'/now() issue with the Que gem and couldn't do it. Regardless, I have no objection to using now(). And yeah, there are occasional test failures on Travis that I've never been able to reproduce on my machine, and that's one of them. I wouldn't worry about it. |
|
Thanks! ✌️ |
|
@chanks could it be that the prepared statements aren't working as expected? |
|
Possibly? I'll open an issue to remind myself to investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument
'now'is evaluated when the statement is prepared, not whenit is executed. So the timestamp in the
insert_jobquery will be staleafter the first execution.
Switching it to
now()ensures that it is always evaluated when the queryis executed.
See bgentry/que-go#1 for more details.
Not sure if you think this needs a test or not, but you'd probably have a better idea of how you want that to look if so.
P.S. I made a golang port of Que :) https://github.com/bgentry/que-go