Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust build behavior based on dev vs prod? #21

Closed
glebec opened this issue Feb 24, 2017 · 3 comments
Closed

Adjust build behavior based on dev vs prod? #21

glebec opened this issue Feb 24, 2017 · 3 comments

Comments

@glebec
Copy link
Contributor

glebec commented Feb 24, 2017

Webpack has a number of options for tailored behavior in dev vs production. For example: cheaper (but still useful) source maps in dev mode; minifying in production; gzipping in production. More info (for v2, mind you) can be found here.

This might add complexity to what is intended to be a small scaffolding base. On the other hand, it can save configuration time and act as a representative example for those interested in implementing such distinctions.

@omriAckley
Copy link

Maybe instead of built-in-from-the-start we talk about it during "deployment training"? I like that idea because then we can bring it up as an interesting option for students who want to try it out. If it's built-in from the start, I worry it'd feel more magical.

@glebec
Copy link
Contributor Author

glebec commented Feb 27, 2017

That makes sense to me. The biggest annoyance from not doing this OOB is performing the very slow full source map generation on every change in watch mode, when much faster and still-usable alternatives exist. My 2c. Perhaps we can enact at least that change, so students can use it as a model for further differentiation.

@glebec
Copy link
Contributor Author

glebec commented Feb 27, 2017

Included, but also set off by default, in https://github.com/FullstackAcademy/bones/commit/5e7415e5f44b2f88f8703a31ac60ebd06a870e04. There is more we could do, so I'll leave this open for now.

@glebec glebec closed this as completed Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants