Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSGi bundle for querydsl-collections #332

Closed
valadan opened this issue Jan 28, 2013 · 3 comments
Closed

OSGi bundle for querydsl-collections #332

valadan opened this issue Jan 28, 2013 · 3 comments
Milestone

Comments

@valadan
Copy link

@valadan valadan commented Jan 28, 2013

Please modify the OSGi manifest for querydsl-collections to make the import package directive for javax.tools optional. It is not used in the OSGi context anyway and it is introducing an unnecessary dependency.

@timowest
Copy link
Member

@timowest timowest commented Jan 28, 2013

Is it implicitly available? querydsl-collections and codegen need the Java Compiler API.

@valadan
Copy link
Author

@valadan valadan commented Jan 28, 2013

Since there is no run-time dependency on the Java Compiler API when used in a OSGi container, I think it is safe to mark the import as optional.

I verified this change on Servicemix (Karaf/Equinox) and everything seems to work fine.

@timowest
Copy link
Member

@timowest timowest commented Feb 20, 2013

Released in 3.0.0.BETA2

@timowest timowest closed this Feb 20, 2013
@timowest timowest added this to the 3.0.0 milestone Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants