OSGi bundle for querydsl-collections #332

Closed
valadan opened this Issue Jan 28, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@valadan

valadan commented Jan 28, 2013

Please modify the OSGi manifest for querydsl-collections to make the import package directive for javax.tools optional. It is not used in the OSGi context anyway and it is introducing an unnecessary dependency.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Jan 28, 2013

Member

Is it implicitly available? querydsl-collections and codegen need the Java Compiler API.

Member

timowest commented Jan 28, 2013

Is it implicitly available? querydsl-collections and codegen need the Java Compiler API.

@valadan

This comment has been minimized.

Show comment
Hide comment
@valadan

valadan Jan 28, 2013

Since there is no run-time dependency on the Java Compiler API when used in a OSGi container, I think it is safe to mark the import as optional.

I verified this change on Servicemix (Karaf/Equinox) and everything seems to work fine.

valadan commented Jan 28, 2013

Since there is no run-time dependency on the Java Compiler API when used in a OSGi container, I think it is safe to mark the import as optional.

I verified this change on Servicemix (Karaf/Equinox) and everything seems to work fine.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Feb 20, 2013

Member

Released in 3.0.0.BETA2

Member

timowest commented Feb 20, 2013

Released in 3.0.0.BETA2

@timowest timowest closed this Feb 20, 2013

@timowest timowest added this to the 3.0.0 milestone Apr 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment