Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSGi bundle for querydsl-collections #332

Closed
valadan opened this issue Jan 28, 2013 · 3 comments
Closed

OSGi bundle for querydsl-collections #332

valadan opened this issue Jan 28, 2013 · 3 comments
Milestone
3.0.0

Comments

@valadan
Copy link

valadan commented Jan 28, 2013

Please modify the OSGi manifest for querydsl-collections to make the import package directive for javax.tools optional. It is not used in the OSGi context anyway and it is introducing an unnecessary dependency.
@timowest
Copy link
Member

Is it implicitly available? querydsl-collections and codegen need the Java Compiler API.

@valadan
Copy link
Author

valadan commented Jan 28, 2013

Since there is no run-time dependency on the Java Compiler API when used in a OSGi container, I think it is safe to mark the import as optional.

I verified this change on Servicemix (Karaf/Equinox) and everything seems to work fine.

timowest added a commit that referenced this issue Jan 29, 2013
@timowest
#332 Make javax.tools optional in OSGI manifest
3b41ada
@timowest
Copy link
Member

Released in 3.0.0.BETA2

@timowest timowest added this to the 3.0.0 milestone Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@valadan @timowest