[#658] Support JPQL Treated paths for WHERE clause #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwgmeligmeyling
added a commit
to jwgmeligmeyling/blaze-persistence-querydsl
that referenced
this pull request
Feb 15, 2020
|
@idosal could you review this one? 😄 |
|
Sure, I'll get on it soon. Sorry for the delay, it kind of fell between the cracks. |
johnktims
approved these changes
May 20, 2020
idosal
approved these changes
May 20, 2020
querydsl-jpa/src/main/java/com/querydsl/jpa/JPAExpressions.java
Outdated
Show resolved
Hide resolved
jwgmeligmeyling
commented
Jul 27, 2020
| * @param <T> the expression type | ||
| * @return subtype instance with the same identity | ||
| */ | ||
| public static <U extends BeanPath<? extends T>, T> U treat(BeanPath<? extends T> path, Class<U> subtype) { |
There was a problem hiding this comment.
@johnktims Apprently this is now considered a breaking change:
Class com.querydsl.jpa.JPAExpressions
Added Method treat, sig <U:Lcom/querydsl/core/types/dsl/BeanPath<+TT;>;T:Ljava/lang/Object;>(Lcom/querydsl/core/types/dsl/BeanPath<+TT;>;Ljava/lang/Class<TU;>;)TU;, desc (Lcom/querydsl/core/types/dsl/BeanPath;Ljava/lang/Class;)Lcom/querydsl/core/types/dsl/BeanPath;, access public static
[WARNING] Rule 0: org.semver.enforcer.RequireBackwardCompatibility failed with message:
Current codebase is not backward compatible (BACKWARD_COMPATIBLE_USER) with version <4.3.2-20200601.233131-46>. Compatibility type has been detected as <NON_BACKWARD_COMPATIBLE>
How should we resolve this? Bump the snapshot version? Move the method to a new class? Add some sort of surpression?
JPA 2.1 introduced the TREAT operator for explicit casting. Initial support for TREAT in the FROM clause was added in PR #705. However, the specification also describes the notion of `treated_subpath` expressions (chapter 4.4.4.1) that are allowed in the WHERE clause of a query. The syntax is as follows: > ``` > treated_subpath ::= TREAT(general_subpath AS subtype) > > single_valued_path_expression ::= qualified_identification_variable | TREAT(qualified_identification_variable AS subtype) | state_field_path_expression | single_valued_object_path_expression > ``` And can be used as such: ```SQL SELECT e FROM Employee e JOIN e.projects p WHERE TREAT(p AS LargeProject).budget > 1000 ``` (Example from chapter 4.4.9). This pull request adds the support for treated subpaths in QueryDSL. It does so by introducing a new `PathType` and convenience method `JPAExpressions.treat`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JPA 2.1 introduced the TREAT operator for explicit casting. Initial support for TREAT in the FROM clause was added in PR #705. However, the specification also describes the notion of
treated_subpathexpressions (chapter 4.4.4.1) that are allowed in the WHERE clause of a query.The syntax is as follows:
And can be used as such:
(Example from chapter 4.4.9).
This pull request adds the support for treated subpaths in QueryDSL. It does so by introducing a new
PathTypeand convenience methodJPAExpressions.treat.Fixes #658
A full list of treat support throughout JPA providers can be found at https://github.com/beikov/jpa-treat-variations