Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two simple histogram examples. #6

Merged
merged 1 commit into from
Aug 30, 2016
Merged

Added two simple histogram examples. #6

merged 1 commit into from
Aug 30, 2016

Conversation

tpapp
Copy link
Contributor

@tpapp tpapp commented Aug 4, 2016

Please check that this is the recommended syntax, I am unsure about using :* to produce "field":"*" but it works.

@coveralls
Copy link

coveralls commented Aug 4, 2016

Coverage Status

Coverage remained the same at 38.636% when pulling e07902b on tpapp:histogram-examples into bfd80b4 on fredo-dedup:master.

@tpapp
Copy link
Contributor Author

tpapp commented Aug 21, 2016

I don't think the test failures happened because of my PR, seems like an idiosyncratic thing. Is there a way to rerun the tests? If there is anything you think is missing from my PR, please let me know and I am happy to add it so it can be accepted.

Same applies to PR #8.

@fredo-dedup fredo-dedup merged commit cefe12c into queryverse:master Aug 30, 2016
@fredo-dedup
Copy link
Collaborator

Looks perfectly fine to me, thanks a lot for your interest and participation @tpapp
Travis failure looks like a timeout and not remated to your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants