-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox is not detected for setup browserbiometrics unless the native-messaging-hosts folder already exists. #37
Comments
Right now I'm stuck here: Brave: Librewolf: I tried downloading the regular Bitwarden application and enabling fingerprint there. I wasn't sure that was the right thing to do but I wondered if it would create the needed folders (it did not) or do something else needed to make the fingerprint auth work: |
Thanks so much for the report. I'll update the wiki. For automatic setup, ideally a folder would be created. The issue is that the nativemessaginghosts folder is used to dynamically detect browsers. When the folder is not present, the best alternative would be to let the user manually select the browser's config directory, or hard-coding some paths. I'll think about this.
The regular linux desktop app does not support biometrics. I do have PR open that adds support: |
For getting your extensions configured in Librewolf and Brave; I have not tested them, but since they are basically just Firefox and Chromium, this should just be a matter of getting the manifest into the correct place. Just to make sure, are the browsers installed as flatpak? (In that case the sandboxing prevents IPC from working) |
Can you try running: And If that doesn't work, I'll install the browsers locally and see what's going on. |
Just released https://github.com/quexten/goldwarden/releases/tag/v0.2.7, which should automatically create the native-messaging-host paths for many browsers, including librewolf and brave. You can try updating, and re-running the setup. |
Hey @quexten, I tried out the new release and it works well, creating the folders where they don't exist. The only thing I get now is this message from Bitwarden to confirm in my desktop application: Which is definitely better than before. I tried purging my vault and logging in again and calling the setup for systemd again. When I check journalctl, this is the output:
I also noticed lines like this:
And I'm not using my local build: With this part I may be missing something simple to tie it all together. I get the same message when I try in Brave as well. Edit for added context, I did have what looked like an error in my polkit setup, but it said it was successful so I figured it was fine.
|
Stuck at the same message, "Awaiting confirmation from Desktop", both in Firefox and Chrome. |
Ah, sorry forgot to follow up on the issue until now. Can either of you compile with |
Hey @quexten, I just emailed you (from your website on your profile) a secure Bitwarden note with the text from the log after pulling the latest main (I redacted some stuff on the lines marked SENSITIVE, but I sent a note expiring in a month just to be safe). I built goldwarden as you instructed, copying to /usr/bin/goldwarden and restarting the systemd service. All I did was attempt to enable biometrics in the extension like before to generate the log. |
The journalctl logs are still just full of |
Thanks a lot for the log!
This is unrelated, but due to keepalives the official server implementation sends, which I have not implemented proper filtering for yet.
This seems to be the issue, for some reason goldwarden - when invoked by your browser - seems not to have a socket path, and thus can't connect to the daemon. The rest of the handshake seems fine. Not entirely sure yet why this is happening, but it's a good clue! |
I think I found the issue (01aca35), should be fixed on the latest master version. |
I tried it out and it worked! The only problem I'm finding now is that my vault keeps getting corrupted like in this issue: #38. The vault purge and log in step fixed it, but I had to do it 2 or 3 times. |
Thanks, closing this now. |
Here is an example to illustrate the issue:
Maybe we could add instructions to the wiki page about this, since I'm not sure if goldwarden is supposed to create the folder, or if the folder is already supposed to exist and for some reason does not.
I personally use librewolf and cloned the repo to add
.librewolf
as a folder to search when I noticed this.The text was updated successfully, but these errors were encountered: