Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute scalingMatrix23 #39

Closed
Tiantian-Han opened this issue May 19, 2020 · 3 comments
Closed

compute scalingMatrix23 #39

Tiantian-Han opened this issue May 19, 2020 · 3 comments
Assignees
@quic-mangal
Labels
question Further information is requested

Comments

@Tiantian-Han
Copy link

file: ModelOptimizations/DlEqualization/src/ScaleFactorCalculator.cpp:
According to the equation on line 102, the calculation on line 132 should be:
reScalingMats->scalingMatrix23.at(s) = (cubeRootMat.at(s)) * (1.0f / rangeVec2.at(s));
???
@quic-akhobare quic-akhobare added the question Further information is requested label May 19, 2020
@quic-akhobare
Copy link
Contributor

@quic-ssiddego, could you please check this?

@quic-akhobare quic-akhobare reopened this May 19, 2020
@quic-mangal
Copy link
Contributor

The comments need to be updated on line 102 ans 103 but the equations are right.

@quic-akhobare
Copy link
Contributor

@quic-mangal, thanks for checking. Please fix the comment :)

@quic-mangal quic-mangal mentioned this issue May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quic-mangal quic-mangal

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Tiantian-Han @quic-mangal @quic-akhobare @quic-ssiddego