Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong gamma and beta for no bn case? #85

Closed
smallzzy opened this issue Jun 11, 2020 · 4 comments
Closed

wrong gamma and beta for no bn case? #85

smallzzy opened this issue Jun 11, 2020 · 4 comments
Assignees
@quic-ssiddego
Labels
question Further information is requested

Comments

@smallzzy
Copy link

for bias_correction.py#L192, gamma is zero and beta is one?
@quic-ssiddego quic-ssiddego added the question Further information is requested label Jun 12, 2020
@quic-ssiddego quic-ssiddego self-assigned this Jun 12, 2020
@quic-ssiddego
Copy link
Contributor

Hi @smallzzy Could you please provide more context for this query?

@smallzzy
Copy link
Author

This code is generating a dummy bn distribution.
But I think a proper bn distribution should have gamma = 1 and beta = 0?

@quic-akhobare
Copy link
Contributor

@smallzzy - :) Thanks for pointing this out. We will check why our tests are passing.

@quic-ssiddego quic-ssiddego mentioned this issue Jun 16, 2020
Merged
@quic-ssiddego
Copy link
Contributor

@smallzzy Thank you for reporting this. Corresponding fix has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quic-ssiddego quic-ssiddego

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smallzzy @quic-akhobare @quic-ssiddego