Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random trigger delays #2482

Closed
wmertens opened this issue Nov 25, 2018 · 6 comments · Fixed by #2500
Closed

Random trigger delays #2482

wmertens opened this issue Nov 25, 2018 · 6 comments · Fixed by #2500

Comments

@wmertens
Copy link
Contributor

wmertens commented Nov 25, 2018

Describe the bug

Sometimes, when I type a keyboard trigger to toggle an application, the command is delayed until I wait about 10s or I type any other key.

To Reproduce

  1. Set up the keyboard shortcut "shift+ctrl+option+cmd+c" to "Toggle visibility of [some application]"
  2. Toggle the application so it's hidden, then don't use it for a while
  3. Type "shift+ctrl+option+cmd+c"

Expected behavior

  1. The application pops up

Actual behavior

  1. Sometimes, the application doesn't pop up. After a few seconds, type the shift key and it pops up immediately

What version of macOS?

Mojave

What version of Quicksilver?

1.6.0.(4025)

@skurfer
Copy link
Member

skurfer commented Nov 28, 2018

I can get this to happen following the steps above. I added some logging and I can tell you the toggle action is running and finishing immediately. So, there’s a delay in the OS somewhere.

The good(ish) news is that building QS with Xcode 10 seems to mysteriously remove the delay. So while it doesn’t seem to be something we can fix, it might get fixed one day.

@wmertens
Copy link
Contributor Author

wmertens commented Mar 20, 2019

So, is building QS with XCode 10 an option? The delays seem to be getting worse :(

@skurfer
Copy link
Member

skurfer commented Mar 20, 2019

You should be able to build the app in Xcode 10, and it will run, but some things are off and there are quite a few nasty warnings in the Console, so it’s not something I’d want to release, but you’re welcome to try it.

Here’s whatever’s currently on the master branch, built with 10: https://qsapp.com/archives/downloads/QS%201.6.0%20Xcode10.dmg

@wmertens
Copy link
Contributor Author

wmertens commented Mar 21, 2019

That works indeed, many thanks!

One issue I'm seeing with it is that using the macOS dark mode messes up the text color in the sidebar of preferences. For the rest everything I use seems to work just fine.

@hmelman
Copy link

hmelman commented Jun 27, 2019

I just upgraded to Mojave (only a little late) and I'm seeing these delays with Toggle Application triggers. I'm using 1.6.0 (4025) on 10.14.5 (18F132) on an iMac using Light Mode. Is there a fix yet?

@hmelman
Copy link

hmelman commented Jun 30, 2019

I tried the Xcode 10 build above, worked fine for a couple of hours then kept crashing. I'm not using Dark Mode.

pjrobertson added a commit that referenced this issue Jul 27, 2019
Deprecate and move away from the old NSWorkspace style app dicts.
This should fix #2482 as well as just generally clean up the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants