Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use "display name" as the label for files #1017

Merged
merged 6 commits into from Aug 21, 2012
Merged

use "display name" as the label for files #1017

merged 6 commits into from Aug 21, 2012

Commits on Jul 24, 2012

  1. use "display name" as the label for files, close #730 

    other clean up:
* don't test for things that are guaranteed to be `nil`
* don't use the same method to set the name and label, only to wipe out label because they match
* reuse the existing `manager` object
    @skurfer
    skurfer committed Jul 24, 2012
    Copy the full SHA
    d650232 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2012

  1. make sure files can be matched on filesystem name, close #952

    @skurfer
    skurfer committed Jul 27, 2012
    Copy the full SHA
    f3ba861 View commit details
    Browse the repository at this point in the history

  2. change the order of things to ensure the best label is chosen 

    Check the bundle for info first. If it just returns the filesystem name, look for a nicer "display name".
    @skurfer
    skurfer committed Jul 27, 2012
    Copy the full SHA
    9935f1e View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2012

  1. only show name if it has a higher rank than label

    @skurfer
    skurfer committed Jul 28, 2012
    Copy the full SHA
    4c9b9ed View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2012

  1. remove a useless condition for preference panes 

    If the file is a preference pane, the method will return before this code is reached. And even if it does get run, on newer versions of OS X, the system will provide a suitable string for `kind`.
    @skurfer
    skurfer committed Jul 30, 2012
    Copy the full SHA
    786749b View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2012

  1. correctly set the name to the filesystem name 

    Blindly calling `lastPathComponent` doesn't account for paths that were localized prior to being passed in.
    @skurfer
    skurfer committed Aug 20, 2012
    Copy the full SHA
    526a810 View commit details
    Browse the repository at this point in the history