Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicksilver only detects folders name in English, not in System Language #730

Closed
souladdon opened this issue Feb 25, 2012 · 10 comments
Closed
Milestone

Comments

@souladdon
Copy link

@souladdon souladdon commented Feb 25, 2012

Hello. I'm trying quicksilver (i already used quicksilver before, but stopped using it when the development stopped) and when i installed it today, i noticed a little bug:

I'm portuguese, so my Document folder is called "Documentos", my Pictures folder is called "Imagens", my "System Preferences" is called "Preferências do Sistema".
When i type for example "Preferências" to open the system preferences, quicksilver doesn't detect it, only if i search for "system preferences", and the same applies to all the system folders and other applications (like activity monitor etc).
Quicksilver doesn't detect the real applications name, detecting instead if typed in english.
Any help on this?

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Feb 25, 2012

Thank you for reporting this.
There are a couple of duplicate reports (#700, #441). I'll keep this one open and collect all the information here.

From issue #700:

QS uses the underlying filename instead of the localized pathname. See https://developer.apple.com/library/mac/#documentation/MacOSX/Conceptual/BPInternational/Articles/LocalizingPathnames.html for more info on the topic.

@souladdon
Copy link
Author

@souladdon souladdon commented Feb 25, 2012

Hm...so, is theres anyway to fix this?

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Feb 28, 2012

I'm sure there is a way to fix it for the developers. As soon as somebody has time to take a look at it. But I can't promise you any kind of timeframe.
And I don't know of any workaround you can use in the meantime. Sorry. :-(

@skurfer
Copy link
Member

@skurfer skurfer commented May 17, 2012

For future reference (after 64-bit changes are merged), I think adding something like this to QSObject (FileHandling) -getNameFromFiles will do the trick:

// try getting display name (kMDItemDisplayName)
if (!newLabel) {
    MDItemRef mdItem = MDItemCreate(kCFAllocatorDefault, (CFStringRef)path);
    if (mdItem) {
        newLabel = (NSString *)MDItemCopyAttribute(mdItem, CFSTR("kMDItemDisplayName"));
    }
}

That method could use some additional clean-up as well. There are a couple of tests on newName in places where it couldn't possibly be anything but nil.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 21, 2012

@skurfer - should we implement your changes?

@skurfer
Copy link
Member

@skurfer skurfer commented Jul 23, 2012

@skurfer - should we implement your changes?

If you and Henning agree that they solve the problem correctly. Don’t trust my opinion on anything containing the string “CF”. :-)

@kristianwa
Copy link

@kristianwa kristianwa commented Nov 23, 2012

I'm still seeing issues with this on ß71 (3936).

My OSX-language is set to Norwegian.

For some system folders Quicksilver detects both the English name of the folder and the Norwegian, e.g. "Pictures"="Bilder", "Movies"="Filmer, "Music"="Musikk", "Public"="Felles".

However, when I try to search for the following folders, QS doesn't detect the localized name, only the English:
/Applications
~/Desktop
~/Documents
~/Downloads

I'm on ML 10.8.2

@skurfer
Copy link
Member

@skurfer skurfer commented Nov 24, 2012

I’m able to reproduce this. Looking into it.

@skurfer
Copy link
Member

@skurfer skurfer commented Nov 25, 2012

Found and fixed the problem. The other devs and I will discuss whether this goes into B71 final or not. (Other than me, they're all outside the U.S., so the chances are pretty good.)

@kristianwa
Copy link

@kristianwa kristianwa commented Nov 25, 2012

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants