-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearing 1st pane on reset #1847
Conversation
Add tests for checking clearing the 1st pane search string and objects under certain scenarios
Nice! I’ll look it over soon. |
Hmmm... @HenningJ - if you have a minute, would you be able to take a look at the new unit testing stuff I've done? I was worried that it might not work with Jenkins, since it requires actually launching Quicksilver, and maybe opening the interface |
(Required for Jenkins to build)
OK, the first problem was just that the QSTest wasn't linked against AppKit. I've done that now, and it seems Jenkins is just stalling :( |
Hmmm... Jenkins Progress:
Not what we really want to see right @HenningJ - I hope I haven't broken anything :o |
I'll try to take a look at it tonight. But starting QS and opening the interface? That doesn't sound like a unit On Wed, May 21, 2014 at 5:09 AM, Rob McBroom notifications@github.comwrote:
|
OK @skurfer - targets removed. Not sure why that happened - I blame it on a buggy Xcode @HenningJ - I'm not too sure if opening the interface (which I do in the unit test) is strictly necessary. If I remove that, there isn't actually anything GUI-ey going on, I make all the calls from code (e.g. I simulate a key down with an |
Well...sounds a little better, but not much. Simulating key events still On Thu, May 22, 2014 at 5:43 PM, Patrick Robertson <notifications@github.com
|
Cool. I guess now Henning won't be able to test the Jenkins build (and all subsequent PR builds will fail), but this branch could always be restored. Any light on the problem @HenningJ ? |
I just got home, so I didn't have a chance to look at anything yet. |
Oh, I didn’t think about that. Sorry. But that assumes we’re right about what’s hanging the test builds to begin with. |
The last few lines for the Jenkins build log that that is indeed the problem:
So, it hangs while it tries to run the "Quicksilver Tests" target. :-( But now that this PR is merged, it triggered a build of the master branch. And of course that hangs as well. So, @pjrobertson could you remove/disable the offending test target and push that directly to master, at least until I figured out how to fix it? |
The 1st commit is unrelated, but quite important.
The 2nd sets up XCode's unit tests (not the Sen Testing framework - I couldn't figure out how to actually launch QS with it) and the 3rd fixes the unit tests I wrote