Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more specific about when the 3rd pane should open/close #2235

Merged
merged 2 commits into from
Jul 18, 2016
Merged

Be more specific about when the 3rd pane should open/close #2235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23f6e59
Only re-adjust the window (show/hide iselector) if a search object vi…
pjrobertson Jul 18, 2016
d7dfafa
Don't close an optional 3rd pane if it has an object
pjrobertson Jul 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Quicksilver/Code-QuickStepInterface/QSResizingInterfaceController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ - (void)adjustWindow:(id)sender {
if (!indirectOptional) {
[self expandWindow:sender];
return;
} else {
} else if ([iSelector objectValue]) {
return;
}else {
NSResponder *firstResponder = [[self window] firstResponder];
if (firstResponder == iSelector
|| firstResponder == [iSelector currentEditor]) {
Expand All @@ -51,12 +53,17 @@ - (void)adjustWindow:(id)sender {
}
}
}
if (expanded) {
[self contractWindow:sender];
}

}

- (void)firstResponderChanged:(NSResponder *)aResponder {
[self adjustWindow:nil];
if (!aResponder || [aResponder isKindOfClass:[QSObjectView class]]) {
// only adjust the window if the search object view has changed (not if another item has taken first responder
[self adjustWindow:nil];
}
}

- (void)expandWindow:(id)sender {
Expand Down