Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query & geocoding #150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jberthier-ma
Copy link

No description provided.

@cjrh
Copy link
Collaborator

cjrh commented Oct 31, 2023

Hi @jberthier-ma, thanks for the contribution 😄

Would you be able to add tests?

The other thing I was wondering was the difference in output for the query __repr__. Could you give an example of the before and after? I am thinking through whether this is a semver break, since it modifies an existing user-facing output, so I want to know whether the change in __repr__ output is worth it.

Sidhant29 pushed a commit to Sidhant29/tantivy-py that referenced this pull request Mar 12, 2024
…-oss#150)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants