Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Aggregation without serde_untagged #2003

Merged
merged 5 commits into from
Apr 25, 2023
Merged

switch to Aggregation without serde_untagged #2003

merged 5 commits into from
Apr 25, 2023

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Apr 18, 2023

  • refactor result handling
  • remove Internal stuff
  • merge different accessors
  • switch to Aggregation without serde_untagged by manually flattening the enum

Closes quickwit-oss/quickwit#1485

@PSeitz PSeitz force-pushed the better_error branch 3 times, most recently from e319baa to 8418e25 Compare April 19, 2023 02:30
@codecov-commenter
Copy link

Codecov Report

Merging #2003 (e841842) into main (c1defdd) will decrease coverage by 0.10%.
The diff coverage is 94.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
- Coverage   94.44%   94.35%   -0.10%     
==========================================
  Files         320      320              
  Lines       59231    59001     -230     
==========================================
- Hits        55943    55669     -274     
- Misses       3288     3332      +44     
Impacted Files Coverage Δ
src/aggregation/agg_result.rs 76.92% <ø> (-1.91%) ⬇️
src/aggregation/bucket/mod.rs 96.15% <ø> (ø)
src/aggregation/metric/mod.rs 94.54% <ø> (ø)
src/aggregation/intermediate_agg_result.rs 95.32% <83.96%> (-2.00%) ⬇️
src/aggregation/bucket/term_agg.rs 97.95% <85.18%> (-0.78%) ⬇️
src/aggregation/agg_req.rs 94.11% <86.51%> (+1.03%) ⬆️
src/aggregation/segment_agg_result.rs 93.18% <94.93%> (-2.75%) ⬇️
src/aggregation/metric/percentiles.rs 89.26% <96.29%> (-2.03%) ⬇️
src/aggregation/metric/stats.rs 92.51% <97.82%> (-5.15%) ⬇️
src/aggregation/agg_bench.rs 100.00% <100.00%> (ø)
... and 7 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz PSeitz merged commit 2e369db into main Apr 25, 2023
@PSeitz PSeitz deleted the better_error branch April 25, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad error message when passing invalid JSON to Aggregation
3 participants