Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DatePrecision to DateTimePrecision #2051

Merged
merged 1 commit into from
May 23, 2023

Conversation

guilload
Copy link
Member

@PSeitz, as discussed on Discord.

@guilload guilload requested a review from PSeitz May 18, 2023 17:45
@guilload guilload force-pushed the guilload/rename-date-precision branch 2 times, most recently from d92926b to 216bbe5 Compare May 18, 2023 17:52
@guilload guilload force-pushed the guilload/rename-date-precision branch from 216bbe5 to 92336e1 Compare May 18, 2023 17:53
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Merging #2051 (92336e1) into main (04562c0) will decrease coverage by 0.01%.
The diff coverage is 93.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2051      +/-   ##
==========================================
- Coverage   94.43%   94.43%   -0.01%     
==========================================
  Files         319      319              
  Lines       59639    59639              
==========================================
- Hits        56322    56318       -4     
- Misses       3317     3321       +4     
Impacted Files Coverage Δ
common/src/lib.rs 91.83% <ø> (ø)
src/lib.rs 98.94% <ø> (ø)
src/schema/mod.rs 100.00% <ø> (ø)
common/src/datetime.rs 66.66% <80.00%> (ø)
src/fastfield/mod.rs 100.00% <100.00%> (ø)
src/fastfield/writer.rs 95.30% <100.00%> (ø)
src/schema/date_time_options.rs 95.45% <100.00%> (ø)
src/schema/schema.rs 98.92% <100.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Contributor

@PSeitz PSeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we don't need the backwards compatibility since it's a breaking change anyway

@guilload
Copy link
Member Author

Just wanted to be gentle on the tantivy users. Do you want me to remove the deprecation stuff? Otherwise, I'll submit a clean-up after PR in one release or two.

@PSeitz
Copy link
Contributor

PSeitz commented May 23, 2023

Okay then let's keep it to getting used to it

@PSeitz PSeitz merged commit a789ad9 into main May 23, 2023
@PSeitz PSeitz deleted the guilload/rename-date-precision branch May 23, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants