Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing query_terms impl for TermSetQuery. #2120

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

adamreichold
Copy link
Collaborator

Closes #2116

@codecov-commenter
Copy link

Codecov Report

Merging #2120 (3f42633) into main (ad76e32) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2120      +/-   ##
==========================================
- Coverage   94.38%   94.37%   -0.01%     
==========================================
  Files         321      321              
  Lines       60809    60815       +6     
==========================================
+ Hits        57393    57394       +1     
- Misses       3416     3421       +5     
Impacted Files Coverage Δ
src/query/set_query.rs 93.10% <0.00%> (-3.33%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trinity-1686a trinity-1686a merged commit 5fafe4b into main Jul 13, 2023
@trinity-1686a trinity-1686a deleted the term-set-query-query-terms branch July 13, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TermSetQuery does not have an impl for Query::query_terms
3 participants