Minor improvements to OwnedBytes #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it obvious where the `StableDerefTrait` is invoked and avoids `transmute` when only a lifetime needs to be extended. Furthermore, it makes use of `slice::split_at` where that seemed appropriate.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2134 +/- ##
=======================================
Coverage 94.39% 94.39%
=======================================
Files 319 319
Lines 60769 60762 -7
=======================================
- Hits 57362 57356 -6
+ Misses 3407 3406 -1
|
fulmicoton
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it obvious where the
StableDerefTraitis invoked and avoidstransmutewhen only a lifetime needs to be extended. Furthermore, it makes use ofslice::split_atwhere that seemed appropriate.