Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in live version--qvis not able to upload qlog files for Visualization. #59

Open
iamPerfPro opened this issue Nov 30, 2021 · 5 comments

Comments

@iamPerfPro
Copy link

Qvis is not able to upload qlog files for visualization.

I uploaded the file using option: 2. I clicked on browse button to upload the file as well as tried to drag and drop using qlog but there is no visualization of the qlog and when I switch the menus to see the trace it still says "Please load a trace file to visualize it".

When I download the source code and try to run it locally on my machine the behavior is the same.

I have used qvis before and it was working fine.

Can You please help in this.

@rmarx
Copy link
Member

rmarx commented Nov 30, 2021

Hello @abnv418,

I seem to be able to load qlog files from disk without issue on https://qvis.quictools.info, so I'm not sure what's going wrong...

Could you maybe attach an example file that doesn't work for your here?
Additionally, could you open up the browser Developer Tools in Chrome and check if there are any red errors in the JavaScript console?
Could you also test option 3 (load pre-made demo files) and see if that works?

Normally, when uploading files to qvis, nothing is actually "uploaded" to the server, so the files are just loaded in your local browser, so it shouldn't be a server-side problem either.

With best regards,
Robin

@iamPerfPro
Copy link
Author

iamPerfPro commented Dec 2, 2021

Hi @rmarx,

Thanks a lot for your reply. I'm attaching a zip file which contains the qlog file and the console error shown. I tried the option 3, It does work. Still the uploaded file is not working.

Please advise what seems to go wrong.

Thanks
Best,
Abhinav
Qlog_client.zip

@rmarx
Copy link
Member

rmarx commented Dec 2, 2021

Hey @abnv418,

The problem seems to be that this file is a newer qlog format (called "draft-02"), but inside the file itself, it claims to be an older format "draft-01" (see the "qlog_version" field at the front of the file). As such, qvis tries to interpret it as the older version, failing to find some fields that were needed then, and failing.

Simply changing the version to "qlog_version": "draft-02" in the qlog works and I can load the file.
It still gives a warning about a missing field that's mandatory in "draft-02", but using the default for that is fine in this case.

I am wondering how you generated this file though... it says the client was aioquic, but AFAIK the current aioquic builds don't have this type of problem. Are you using a custom version or should we create an issue at aioquic as well to fix this?

With best regards,
Robin

@iamPerfPro
Copy link
Author

Hi @rmarx ,

Thanks for your prompt reply. I'm using a custom version of aioquic. There is nothing wrong in aioquic.

I also checked from my side after changing the draft-02 in the qlog file it shows a message of non compliant qlog-draft. Is this the same warning which you also get ? Attaching the screen shot for your reference.

Just wanted to confirm with you that this pop up does not impact the visualization in any way ? Is there any way I can generate the draft-1 qlog file or do something to remove this warning .

Please guide.

Thanks.

Best,
Abhinav
Screen Shot 2021-12-02 at 11 15 30 AM

@rmarx
Copy link
Member

rmarx commented Dec 2, 2021

Hey @abnv418,

good to hear there's nothing wrong with aioquic :)

That is indeed the warning that I get as well, which can be easily solved by adding the "qlog_format": "JSON" field at the same level as the "qlog_version" field (e.g., right before/after it). See an example here: https://quicwg.org/qlog/draft-ietf-quic-qlog-main-schema-01/draft-ietf-quic-qlog-main-schema.html#name-the-high-level-qlog-schema. That should make the file (more) draft-02 compliant.

"JSON" is the default value for that field, so it just works, but qvis shows the warning to try and force people to make more compliant qlogs for more recent versions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants