Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server's initial plaintext packet should be PMTU sized #1010

Closed
janaiyengar opened this issue Dec 12, 2017 · 5 comments
Closed

Server's initial plaintext packet should be PMTU sized #1010

janaiyengar opened this issue Dec 12, 2017 · 5 comments
Assignees
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@janaiyengar
Copy link
Contributor

Sec 9 should include this, without which the PMTU discovery that happens with client + server handshake packets is not complete.

@mnot mnot added -transport editorial An issue that does not affect the design of the protocol; does not require consensus. labels Dec 12, 2017
@huitema
Copy link
Contributor

huitema commented Dec 13, 2017

I was thinking, what about DOS amplification attacks, if the server plaintext is larger than the client initial? But in fact, the server plain text is already larger than the client initial -- certificates are large enough to often require two packets.

@huitema
Copy link
Contributor

huitema commented Dec 13, 2017

OTOH, I would not call that PMTU discovery. You are speaking about the minimum MTU of 1532/1552 bytes, right?

Another way to see that is that the server should assume that the "guaranteed" MTU is at most the size of the largest packet that it sent during the handshake.

@janaiyengar
Copy link
Contributor Author

@huitema: Yes, exactly. There's no text right now for the server to know what it's max packet size ought to be. I was going to suggest that the server use the size of the client's first packet, unless it knows that the PMTU in the server -> client direction is smaller, in which case, it uses a smaller size. Either ways, this ought to become the max packet size for the server.

@ianswett
Copy link
Contributor

ianswett commented Oct 2, 2018

PR #1013 is very bit-rotten.

I think the current text is sufficient? It was updated after the new crypto handshake design.
https://github.com/quicwg/base-drafts/blob/master/draft-ietf-quic-transport.md#packet-size-packet-size

@janaiyengar
Copy link
Contributor Author

Yup, this is dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

4 participants