Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid TLS-level KeyUpdate in draft-ietf-quic-tls #1833

Closed
davidben opened this issue Oct 4, 2018 · 3 comments
Closed

Forbid TLS-level KeyUpdate in draft-ietf-quic-tls #1833

davidben opened this issue Oct 4, 2018 · 3 comments
Labels
-tls design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@davidben
Copy link

davidben commented Oct 4, 2018

Since QUIC uses its own mechanism, the spec should say the TLS-level KeyUpdate MUST NOT be sent and MUST be treated as a fatal error on receive.

Otherwise an implementation may forget about this and, when TLS sees a KeyUpdate, call some callback in some weird unexpected way and confuse things.

@mikkelfj
Copy link
Contributor

mikkelfj commented Oct 4, 2018

There must be some form of key update otherwise GCM is not safe on long running connections.

@MikeBishop
Copy link
Contributor

There is. TLS, section 6.

@MikeBishop MikeBishop added design An issue that affects the design of the protocol; resolution requires consensus. -tls labels Oct 4, 2018
@davidben
Copy link
Author

davidben commented Oct 4, 2018

Right. Thus "[s]ince QUIC uses its own mechanism". :-)

Either way, the KeyUpdate message should be discussed in that text somewhere. If QUIC replaces it with its own mechanism, the spec text should forbid it. If QUIC makes TLS-level KeyUpdate somehow meaningful, it's got to actually specify what it does. QUIC handles record encryption and isn't ordered like TCP. The existing TLS KeyUpdate behavior doesn't apply.

@mnot mnot added the has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-tls design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Development

No branches or pull requests

4 participants