Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking duplicate TPs is onerous #2689

Closed
dtikhonov opened this issue May 10, 2019 · 3 comments · Fixed by #2691
Closed

Checking duplicate TPs is onerous #2689

dtikhonov opened this issue May 10, 2019 · 3 comments · Fixed by #2691
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@dtikhonov
Copy link
Member

Unlike HTTP/3 settings, receipt of duplicated transport parameters must be treated as an error:

                                                    An endpoint MUST
   treat receipt of duplicate transport parameters as a connection error
   of type TRANSPORT_PARAMETER_ERROR.

Why the inconsistency?

The checks for duplicated transport (or settings) parameters are expensive, because one has to maintain an arbitrarily-sized set of possibly large numbers.

I propose we switch the duplicate transport parameters enforcement to "MAY treat as error."

@ianswett
Copy link
Contributor

I'm fine with MUST not send duplicates, MAY treat receipt as an error.

@MikeBishop
Copy link
Contributor

Fine by me.

@janaiyengar
Copy link
Contributor

Yup, seems sensible to me.

@martinthomson martinthomson added the proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. label May 12, 2019
@mnot mnot added the design An issue that affects the design of the protocol; resolution requires consensus. label May 22, 2019
@mnot mnot added has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. and removed proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. labels Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants