Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing return statements #309

Closed
martinthomson opened this issue Feb 15, 2017 · 1 comment
Closed

Missing return statements #309

martinthomson opened this issue Feb 15, 2017 · 1 comment
Assignees
@ianswett
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@martinthomson
Copy link
Member

The descriptions for OnAlarm and OnPacketAcked both claim a return value. The pseudocode doesn't show any return value.
@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -recovery labels Feb 15, 2017
@ianswett ianswett self-assigned this Mar 6, 2017
@ianswett
Copy link
Contributor

ianswett commented Mar 7, 2017

This has already been fixed.

@ianswett ianswett closed this as completed Mar 7, 2017
@ianswett ianswett added editorial An issue that does not affect the design of the protocol; does not require consensus. and removed design An issue that affects the design of the protocol; resolution requires consensus. labels Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianswett ianswett

Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinthomson @ianswett