Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs #3703

Closed
marten-seemann opened this issue May 27, 2020 · 1 comment · Fixed by #3691
Closed

use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs #3703

marten-seemann opened this issue May 27, 2020 · 1 comment · Fixed by #3691
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@marten-seemann
Copy link
Contributor

The guiding principle here (as we apply it for FRAME_ENCODING_ERRORs) is that if an error is detectable without accessing connection state, we use the more specific error. So for example, since initial_source_connection_id and original_destination_connection_id are required transport parameters, their absence should be responded to with a TRANSPORT_PARAMETER_ERROR. A similar argument applies to the absence of the retry_source_connection_id TP, although I can see how one might use PROTOCOL_VIOLATION here (note that this is still valid behavior with this PR, as every more specific error can be replaced with a PROTOCOL_VIOLATION, if an implementation wishes to do so).

@martinthomson
Copy link
Member

Thanks. I think that this is fine. I will make a few editorial comments on the PR, but I think that the application of the agreed principles is correct.

@LPardue LPardue added the design An issue that affects the design of the protocol; resolution requires consensus. label Jun 1, 2020
@janaiyengar janaiyengar added the proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. label Jun 1, 2020
@LPardue LPardue added call-issued An issue that the Chairs have issued a Consensus call for. and removed proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. labels Jun 2, 2020
@LPardue LPardue added has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. and removed call-issued An issue that the Chairs have issued a Consensus call for. labels Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants