Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infinite loop of OnLossDetectionTimeout #3967

Closed
kazu-yamamoto opened this issue Jul 29, 2020 · 2 comments
Closed

infinite loop of OnLossDetectionTimeout #3967

kazu-yamamoto opened this issue Jul 29, 2020 · 2 comments
Labels
invalid A duplicate, overcome-by-events, ill-formed, or off-topic issue, or a question better asked on-list.

Comments

@kazu-yamamoto
Copy link
Contributor

OnLossDetectionTimeout in the recovery draft always calls SetLossDetectionTimer, resulting in an infinite loop which continues even after the connection is closed. It would be nice if conditions such as if (connection is open): are added or comments are added.
@marten-seemann
Copy link
Contributor

SetLossDetectionTimer cancels the timer when there are no ack-eliciting packets in flight, so I can't see how this would create an infinite loop. I'd prefer to not further complicate the pseudo-code here for this corner case.

@kazu-yamamoto
Copy link
Contributor Author

@marten-seemann You are right. My interpretation and implementation was wrong. Thank you for pointing out.

@kazu-yamamoto kazu-yamamoto mentioned this issue Jul 29, 2020
Closed
@martinthomson martinthomson added the invalid A duplicate, overcome-by-events, ill-formed, or off-topic issue, or a question better asked on-list. label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid A duplicate, overcome-by-events, ill-formed, or off-topic issue, or a question better asked on-list.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martinthomson @kazu-yamamoto @marten-seemann