Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When to reduce cwnd in recovery #4050

Closed
mirjak opened this issue Aug 25, 2020 · 2 comments
Closed

When to reduce cwnd in recovery #4050

mirjak opened this issue Aug 25, 2020 · 2 comments

Comments

@mirjak
Copy link
Contributor

mirjak commented Aug 25, 2020

The recovery draft currently has the following text:

When slow start is exited, the congestion
window halves and the slow start threshold is set to the new congestion
window.

However, in https://tools.ietf.org/html/rfc5681#section-4.3 ssthresh is reduced upon entering recovery but cwnd is set to ssthresh when leaving recovery.

There is more discussion on this already in PR #3978 and PR #4005.

@ianswett proposed by email the following alternative wording:

MUST reduce the CWND to the ssthresh by the time recovery is exited and implementations MAY use a variety of mechanisms to reduce bytes in flight, including reducing it immediately, packet conservation, PRR(RFC6937) or decreasing the pacing rate.

@janaiyengar noted this text from RFC5861 which works as well:

   Second, until all lost segments in the window of data in question are
   repaired, the number of segments transmitted in each RTT MUST be no
   more than half the number of outstanding segments when the loss was
   detected.
@janaiyengar
Copy link
Contributor

This discussion belongs in #3944, since #3978 hasn't been merged yet. Let's move this there.

@larseggert
Copy link
Member

I'll close this one, since we have #3944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants