Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce draining period for connection termination #748

Closed
martinthomson opened this issue Aug 24, 2017 · 2 comments
Closed

Introduce draining period for connection termination #748

martinthomson opened this issue Aug 24, 2017 · 2 comments
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@martinthomson
Copy link
Member

martinthomson commented Aug 24, 2017

Feedback on what was an editorial change in #721 turned it into a substantial change. Apparently we are now specifying what different peers do during shutdown in new and interesting ways.

@martinthomson martinthomson added -transport design An issue that affects the design of the protocol; resolution requires consensus. labels Aug 24, 2017
@huitema
Copy link
Contributor

huitema commented Aug 24, 2017

I like the new text. It does result in reliable close. Just one nit: if the sender of the connection close receives an ACK for the packet carrying the connection close frame, it is probably OK to exit the draining state sooner.

Of course, when we study multipath, we will have to differentiate between closing a path and closing the connection...

@martinthomson
Copy link
Member Author

Apparently the "closes/fixes" trick only works for those issues that were mentioned at first. You can't add more later by editing the comment (that's weak-sauce GitHub).

@mnot mnot added the has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Development

No branches or pull requests

3 participants