Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include blocking state in BLOCKED / STREAM_BLOCKED / STREAM_ID_BLOCKED #927

Closed
MikeBishop opened this issue Nov 14, 2017 · 1 comment
Closed

Include blocking state in BLOCKED / STREAM_BLOCKED / STREAM_ID_BLOCKED #927

MikeBishop opened this issue Nov 14, 2017 · 1 comment
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@MikeBishop
Copy link
Contributor

This has been suggested a couple times, most recently by @marten-seemann in #924: If the flow control debug frames included the value of the block the sender is hitting, it simplifies a couple things:

  • The receiver can know whether they've unblocked the sender already
  • Differences between the two sides' view of the connection window can be identified
  • Retransmission logic might be easier, since it becomes easier to identify whether the state has changed

Splitting this off to unblock the other PR.
@MikeBishop MikeBishop added -transport design An issue that affects the design of the protocol; resolution requires consensus. labels Nov 14, 2017
@marten-seemann marten-seemann mentioned this issue Nov 14, 2017
Merged
@martinthomson
Copy link
Member

This duplicates #452, which @MikeBishop shouldn't have closed with #924.

@MikeBishop MikeBishop mentioned this issue Dec 1, 2017
Closed
@mnot mnot added the has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martinthomson @mnot @MikeBishop