-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception in ECN detection when ACK loss happens #1555
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5f0d7b1
Merge tag 'draft-ietf-quic-transport-13' of https://github.com/quicwg…
gloinul d5729ff
Adding exception due to ack loss.
gloinul 1d37a4c
Fixing trailing spaces.
gloinul 261c0e7
Implementing Ian's proposals
gloinul 03ddb3e
Addressing editorial from Ian
gloinul 7687a00
Fixing spelling of comparisons
gloinul 2a32722
Removed extra empty line.
gloinul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1739,12 +1739,14 @@ network, an endpoint verifies the following when an ACK_ECN frame is received: | |
* The increase in ECT(0) and ECT(1) counters MUST be no greater than the number | ||
of packets newly acknowledged that were sent with the corresponding codepoint. | ||
|
||
* If the increase in the ECT(0), ECT(1) and CE counters are greater than the | ||
number of newly ACKed packets, and received ACK's smallest acknowledged is | ||
larger than the previous largest acknowledged, then it's likely | ||
acknowledgements were missed, and the above comparison MUST NOT be | ||
performed. Instead a new comparision point is stored by the sender so that | ||
only changes after this point will be used in the future comaparisions. | ||
* If the increase in the ECT(0), ECT(1) and CE counters are greater than | ||
the number of newly acknowledged packets, and the received ACK's | ||
smallest acknowledged is larger than the previous largest acknowledged, | ||
then it's likely acknowledgements were missed, and the above comparison | ||
MUST NOT be performed. Instead a new comparision point is stored by the | ||
sender so that only changes after this point will be used in the future | ||
comaparisions. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mikkel's right, comaparisons -> comparisons |
||
|
||
|
||
Upon successful verification, an endpoint continues to set ECT codepoints in | ||
subsequent packets with the expectation that the path is ECN-capable. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I pointed out, this isn't ideal and will lead to ECN being disabled in some cases. I don't know how much we are going to want to worry about that though.