Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception in ECN detection when ACK loss happens #1555

Merged
merged 7 commits into from
Jul 14, 2018
Merged

Exception in ECN detection when ACK loss happens #1555

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f0d7b1
Merge tag 'draft-ietf-quic-transport-13' of https://github.com/quicwg…
gloinul Jul 12, 2018
d5729ff
Adding exception due to ack loss.
gloinul Jul 12, 2018
1d37a4c
Fixing trailing spaces.
gloinul Jul 12, 2018
261c0e7
Implementing Ian's proposals
gloinul Jul 12, 2018
03ddb3e
Addressing editorial from Ian
gloinul Jul 13, 2018
7687a00
Fixing spelling of comparisons
gloinul Jul 13, 2018
2a32722
Removed extra empty line.
gloinul Jul 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1738,6 +1738,14 @@ network, an endpoint verifies the following when an ACK_ECN frame is received:

* The increase in ECT(0) and ECT(1) counters MUST be no greater than the number
of packets newly acknowledged that were sent with the corresponding codepoint.

* If the increase in the ECT(0), ECT(1) and CE counters are greater than the
number of newly ACKed packets, and received ACK's smallest acknowledged or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just say "ACK's smallest acknowledged" and drop "or gap indicated packet number"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented.

gap indicated packet number is larger than previously largest acknowledged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: "...larger than the previous largest acknowledged, then it's likely acknowledgements were missed, and the above comparison MUST NOT be performed."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented

packet known by the sender, i.e. there exist a lack of information, then the
above comparisions MUST NOT be performed. Instead a new comparision point
is stored by the sender so that only changes after this point will be used
in the future comaparisions.

Upon successful verification, an endpoint continues to set ECT codepoints in
subsequent packets with the expectation that the path is ECN-capable.
Expand Down