Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Spin bit for what percentage of connections? #3270

Closed
wants to merge 1 commit into from

Conversation

igorlord
Copy link
Contributor

@igorlord igorlord commented Nov 20, 2019

Clarify the fractions of connections an endpoint must disable spin bit for.
Fixes #3257.
Closes #2628.

the spin bit for at least a sixteenth of connections with an expectation that
the spin bit is disabled for at least one eighth of network paths. The selection
process performed at the beginning of the connection SHOULD be applied for all
paths used by the connection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reviewing this last sentence, I am reminded that this provides a nice signal that might improve linkability. I think that the requirement to perform the determination separately for every network path/connection ID as suggested above is better.

performed at the beginning of the connection SHOULD be applied for all paths
used by the connection.
the spin bit for at least a sixteenth of connections with an expectation that
the spin bit is disabled for at least one eighth of network paths. The selection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoints MUST disable their use of the spin bit on at least one in every 16 network paths, or for one in every 16 connection IDs. This ensures that the spin bit signal is disabled on approximately one in eight network paths.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinthomson If we are to "ensure" that the spin bit signal would be disabled for approx. 1/8 of network paths, I think we need to require endpoints to select one in every 16 paths at random. Otherwise, the paths that would have the spin bit disabled could go below 1/8. For example, when there is only one client and one server talking to each other, and if both of them disable spin bit for every 16th connection they handle, then the spin bit would be enabled for only 1/16 of all the connections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite right.

endpoints MUST disable their use of the spin bit for a random selection of at least one in every 16 network paths, or for one in every 16 connection IDs. This ensures that the spin bit signal is disabled on approximately one in eight network paths.

@martinthomson martinthomson added -transport editorial An issue that does not affect the design of the protocol; does not require consensus. labels Dec 3, 2019
martinthomson added a commit that referenced this pull request Dec 11, 2019
This addresses linkability concerns.

Builds on #3270 and includes suggested improvements.

Closes #3270.
Closes #3257.
Closes #2628.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling Spin bit for what percentage of connections?
3 participants