Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATH_CHALLENGE as an explicit signal in path initialization. #261

Open
yfmascgy opened this issue Jul 8, 2023 · 5 comments
Open

PATH_CHALLENGE as an explicit signal in path initialization. #261

yfmascgy opened this issue Jul 8, 2023 · 5 comments

Comments

@yfmascgy
Copy link
Contributor

yfmascgy commented Jul 8, 2023

I think this issue repeats some of discussions we had earlier regarding using path_challenge as an explicit signal during a path creation. The inclusion of a client initiated path_challenge frame helps differentiate a path creation from a simultaneous NAT rebinding and CID rotation.

My question is do we want to state such a role of path_challenge more explicitly in this draft? I find people may still be confused about that, and such a sentence could clarify things a lot. Currently, in our implementation, yes, we use PATH_CHALLENGE as an explicit signal when creating a new path. The logic on the server is to first process a path_challenge_frame and if the server does not find a path associated with the in-coming packet's dcid, then try to create a new path and validate the client's address.

@huitema
Copy link
Contributor

huitema commented Jul 9, 2023

I don't think we should change the meaning of "path challenge" -- it has other use than path initialization. But I also think that we have an issue about the default state of paths. It would be nice to add a recommendation to bundle a "path status" with the "path challenge" when the client is probing a new path, so the peer knows whether the intended status is "standby" or "available".

@huitema
Copy link
Contributor

huitema commented Jul 9, 2023

We also have the related issue #188: packets that arrive on a new path and do not contain a PATH CHALLENGE frame.

@mirjak
Copy link
Collaborator

mirjak commented Oct 21, 2023

I don't think we should change the meaning of "path challenge" -- it has other use than path initialization. But I also think that we have an issue about the default state of paths. It would be nice to add a recommendation to bundle a "path status" with the "path challenge" when the client is probing a new path, so the peer knows whether the intended status is "standby" or "available".

@huitema this part is addresses now with PR #277

@yfmascgy is there anything else we want to do here or can we close this issue?

@michael-eriksson
Copy link

As proposed in #180, path setup should be really explicit and not just some overloaded semantics of the PATH_CHALLENGE frame. A PATH_SETUP frame can't be misunderstood and would include all necessary information, including the initial path status.

@mirjak
Copy link
Collaborator

mirjak commented Nov 3, 2023

Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants