-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "initial_max_paths / MAX_PATHS" to "intial_max_path_id / MAX_PATH_ID" ? #324
Comments
the current draft (-07) uses MAX_PATH to announce the max number of paths and not the largest path ID that can be used. So the name matches the meaning, I would say. Is this issue to discuss to use the max path ID instead (or was this just about aligning the naming)? |
This is an entire mess right now in the draft: initial_max_path is defined like this (as the max number of path):
MAX_PATH is defined like this however:
|
I created PR #354 to fix the definition of the MAX_PATHS frame now actually indicating the largest Path ID that can be used. However, initial_max_paths is still defined as the max number of paths (and also thereby also indicate the max path ID at the beginning when no MAX_PATHS frame was received yet). Do we want to change this? |
Yes we do. the "initial_max_path" frame shall be the same as "the first MAX PATH frame received on the connection". |
I revised #354 |
#354 is merged. Frame is now MAX_PATHS and parameter is max_initial_paths. We could still discuss if this naming should be revised but at least it now consistent and more clearly described in the draft. I will close this issue for now. However, you can reopen or open a new issue if you want further discussion. |
Record from comments:
marten-seemann 4 days ago
michael-eriksson 4 days ago
marten-seemann 4 days ago
michael-eriksson 3 days ago
The text was updated successfully, but these errors were encountered: