Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise design of dual-endpoint events #44

Closed
rmarx opened this issue Jan 21, 2020 · 2 comments
Closed

Revise design of dual-endpoint events #44

rmarx opened this issue Jan 21, 2020 · 2 comments

Comments

@rmarx
Copy link
Contributor

rmarx commented Jan 21, 2020

Currently, we have some events that are used both for indicating changes in the local as well as the remote endpoint. An example is parameters_set, which logs both connection params we set locally, as the ones we get from the other side. parameters_set uses an "owner" field to disambiguate between these two cases.

However, other events with similar purpose, like connection_id_updated, use another approach (src_ vs dst_ prefixes). We should decide on a singular consistent approach (currently leaning towards "owner" field myself, as it is the most flexible)

@rmarx rmarx added the future-versions issue will be tackled but not for the current iteration label Oct 31, 2020
@rmarx rmarx added current-version design and removed future-versions issue will be tackled but not for the current iteration labels Aug 18, 2021
@LPardue
Copy link
Member

LPardue commented Sep 7, 2022

Is this still relevant?

@rmarx
Copy link
Contributor Author

rmarx commented Feb 19, 2024

Given that there have been no further complaints/remarks on this and imo the split approach is clear enough, closing without action for now.

@rmarx rmarx closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants