Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in Registry.query #13

Closed
gregdetre opened this issue Sep 19, 2016 · 1 comment
Closed

Possible typo in Registry.query #13

gregdetre opened this issue Sep 19, 2016 · 1 comment

Comments

@gregdetre
Copy link

I was reading through the Parchment source code, and this line looked odd:

https://github.com/quilljs/parchment/blob/master/src/registry.ts#L81

Shouldn't that be a test for equality, rather than an assignment? i.e.

if (match === classes[names[i]]) ...

Apologies if I've misunderstood the intent of the code, or if there's some javascript cleverness here I'm missing. Thanks for all your hard work on Quill and Parchment!

@jhchen jhchen closed this as completed in 8bce722 Sep 21, 2016
jhchen added a commit that referenced this issue Sep 21, 2016
closes #13
@jhchen
Copy link
Member

jhchen commented Sep 21, 2016

It was being too clever thank you for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants