Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link formatting logic should not force https #21

Closed
jhchen opened this issue May 2, 2013 · 1 comment
Closed

Link formatting logic should not force https #21

jhchen opened this issue May 2, 2013 · 1 comment
Assignees
@jhchen

Comments

@jhchen
Copy link
Member

jhchen commented May 2, 2013

If user specifies http, leave as http. We force a protocol to prevent xss. Perhaps a better algorithm is keep either http or https, otherwise, strip the protocol?
@ghost ghost assigned jhchen May 2, 2013
@jhchen
Copy link
Member Author

jhchen commented Jul 12, 2013

Now only allows http or https. If any other (or none), changes to http.

@jhchen jhchen closed this as completed Jul 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhchen jhchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhchen