Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if keyboard shortcut used for unavailable format #432

Closed
rlivsey opened this issue Jul 29, 2015 · 0 comments
Closed

Error if keyboard shortcut used for unavailable format #432

rlivsey opened this issue Jul 29, 2015 · 0 comments

Comments

@rlivsey
Copy link

rlivsey commented Jul 29, 2015

Given an editor setup with just bold format available:

new Quill(".editor", {
  formats: ['bold']
});

If a user hits the shortcut for italic then it fails because @editor.doc.formats[name] is undefined here:

screenshot 2015-07-29 11 30 09

Does this need a check for whether or not the format is available, or should Keyboard even be bound to the hotkey if it's not available?

@jhchen jhchen closed this as completed in c5d2ede Aug 4, 2015
thomsbg added a commit to voxmedia/quill that referenced this issue Aug 7, 2015
jhchen added a commit that referenced this issue Aug 7, 2015
Alternative fix for #432 that also works with formats added via quill.addFormat()
jhchen pushed a commit that referenced this issue Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant