Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't toggle off code block formatting #789

Closed
sachinrekhi opened this issue Jul 12, 2016 · 6 comments
Closed

Can't toggle off code block formatting #789

sachinrekhi opened this issue Jul 12, 2016 · 6 comments

Comments

@sachinrekhi
Copy link
Contributor

You can no longer toggle off code block formatting after applying it.

This appears to be a regression from Quill 1.0 Beta 6

Steps for Reproduction

  1. Visit beta.quilljs.com
  2. Clear editor
  3. Add a line of text
  4. Select full line of text
  5. Format using the code block icon in the toolbar
  6. Select full line of text again
  7. Hit the code block icon in the toolbar again to toggle off code block formatting

Expected behavior:
The text no longer is formatted in a code block

Actual behavior:
The text remains formatted in a code block

Platforms:
Chrome 51 on Mac 10.11

Version:
Quill 1.0 Beta 8

@jhchen
Copy link
Member

jhchen commented Jul 12, 2016

This change 9ea959d seems to have fixed the issue in the 1.0 branch.

@dhershman1
Copy link

I still seem to be having issues with when I start a code block and then click it again to end or try to leave the code block I am stuck, if I don't leave a space to click out of I would be stuck unless I created a blockquote or something else

@sachinrekhi
Copy link
Contributor Author

@dhershman1 are you using Quill 1.0 Beta 8? If so, the fix has not yet been pushed to a new release. Will be in next release.

@dhershman1
Copy link

Well that explains it, I guess I didn't notice when I looked lol.

@jhchen jhchen closed this as completed Jul 19, 2016
@sachinrekhi
Copy link
Contributor Author

I'm still seeing this issue occur in Quill 1.0 Beta 9 in certain cases.

Slightly different repro:

  1. Visit beta.quilljs.com
  2. Clear editor
  3. Type "test" on the first line
  4. Hit enter & enter
  5. Type "some code" on next line
  6. Type "again" on the next line
  7. Highlight some code & again lines and apply code block formatting
  8. Attempt to remove code block formatting from the last "again" line

screen shot 2016-07-18 at 6 58 49 pm

@naveenkn456
Copy link

Is this resolved? I am facing the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants