Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard default config object merged into options twice #897

Closed
cgilboy opened this issue Aug 29, 2016 · 0 comments
Closed

Keyboard default config object merged into options twice #897

cgilboy opened this issue Aug 29, 2016 · 0 comments

Comments

@cgilboy
Copy link

cgilboy commented Aug 29, 2016

It appears that Keyboard.DEFAULT object is merged twice into the options object that is used to construct the Keyboard module.

This happens once in expandConfig quill.js where they have been plucked off of the Keyboard.DEFAULTS on line 349 viamoduleClass.DEFAULTS, and then again later in the Keyboard constructor.

I'm not sure what the project strategy is for configuring module defaults, but this double-merge seems unintended.

@jhchen jhchen closed this as completed in 5635f5d Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant