Fix package browsing #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a type-key to the top-level to make it a “GROUP” node to fix package browsing.
|
True, we could do that, but we'd break existing packages. Are we still early enough that that's a better option? |
|
Probably fine to break... Though you could do both, and add a TODO to remove the code that adds the key when reading the package. |
dimaryaz
reviewed
Mar 9, 2017
| @@ -315,6 +316,7 @@ def _add_to_contents(self, fullname, objhash, ext, path, target): | |||
| leaf = ipath.pop() | |||
|
|
|||
| ptr = contents | |||
| ptr.setdefault(TYPE_KEY, NodeType.GROUP.value) | |||
There was a problem hiding this comment.
Why not just make sure get_contents always returns a dict with the key? If the package doesn't have any objects, this won't run, right?
quilt/tools/store.py
Outdated
| @@ -129,6 +129,8 @@ def get_contents(self): | |||
| try: | |||
| with open(self._path, 'r') as contents_file: | |||
| contents = json.load(contents_file) | |||
| # Make the top-level a GROUP node | |||
| contents[TYPE_KEY] = NodeType.GROUP.value | |||
There was a problem hiding this comment.
Just move this to the end of the function, before return - I think that should take care of everything?
dimaryaz
approved these changes
Mar 9, 2017
| @@ -315,6 +316,7 @@ def _add_to_contents(self, fullname, objhash, ext, path, target): | |||
| leaf = ipath.pop() | |||
|
|
|||
| ptr = contents | |||
| ptr.setdefault(TYPE_KEY, NodeType.GROUP.value) | |||
There was a problem hiding this comment.
This is unnecessary now, right?
nl0
pushed a commit
that referenced
this pull request
Dec 7, 2019
nl0
pushed a commit
that referenced
this pull request
Dec 9, 2019
nl0
added a commit
that referenced
this pull request
Dec 9, 2019
* master: Update dependency vega to ^5.9.0 (#34) Update babel monorepo to ^7.7.5 (#31) Update dependency eslint-plugin-redux-saga to ^1.1.3 (#32) Update dependency terser-webpack-plugin to ^1.4.2 (#33) Update dependency @sentry/browser to ^5.10.1 (#27) Update dependency fetch-mock to ^8.0.1 (#28) Update dependency use-debounce to ^3.3.0 (#29) Update dependency react-app-polyfill to ^1.0.5 (#30) Update mui monorepo to ^4.7.1 (#25) Update dependency css-loader to ^3.2.1 (#21) Update dependency use-debounce to ^3.2.0 (#24) Update dependency eslint to ^6.7.2 (#22) Update dependency eslint-plugin-react to ^7.17.0 (#23) Update dependency aws-sdk to ^2.582.0 (#1) Update dependency style-loader to ^1.0.1 Update dependency lint-staged to ^9.5.0 Update dependency coveralls to ^3.0.9 Update dependency connected-react-router to ^6.6.1 Update renovate.json
nl0
added a commit
that referenced
this pull request
Dec 11, 2019
* master: (48 commits) Better package list ux pt. 1: larger hit area (whole tile) (#1439) Fix interrupted downloads causing corrupted manifests (#1438) Fixed missing @ for decorator (#1441) PyPi improvements - VERSION file and CircleCi support for alpha releases (#1427) Fix Telemetry double counting (#1426) preview bio files as plain text (#1435) Link to open data (#1434) Update dependency @material-ui/core to ^4.7.2 (#37) Update dependency @babel/preset-env to ^7.7.6 (#38) Update dependency eslint-import-resolver-webpack to ^0.12.0 (#39) Update dependency vega to ^5.9.0 (#34) Update babel monorepo to ^7.7.5 (#31) Update dependency eslint-plugin-redux-saga to ^1.1.3 (#32) Update dependency terser-webpack-plugin to ^1.4.2 (#33) Update dependency @sentry/browser to ^5.10.1 (#27) Update dependency fetch-mock to ^8.0.1 (#28) Update dependency use-debounce to ^3.3.0 (#29) Update dependency react-app-polyfill to ^1.0.5 (#30) Update mui monorepo to ^4.7.1 (#25) Update dependency css-loader to ^3.2.1 (#21) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the top-level of contents a group node.