-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArrowPackageStore #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an enum to track package format choices.
# Conflicts: # quilt/tools/const.py # quilt/tools/store.py
Package inspection used to require h5py, but now works on the package.json file so those tests don’t need to be skipped if h5py is missing.
# Conflicts: # quilt/tools/command.py # quilt/tools/const.py # quilt/tools/store.py
dimaryaz
reviewed
Mar 11, 2017
quilt/test/test_push.py
Outdated
obj_type = NodeType(obj[TYPE_KEY]) | ||
if obj_type is NodeType.TABLE or obj_type is NodeType.FILE: | ||
yield from obj["hashes"] | ||
hash_it = iter(obj['hashes']) | ||
yield next(hash_it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure you need a loop here and below? Doesn't this just return the first item?
quilt/tools/store.py
Outdated
""" | ||
Creates a DataFrame from a set of objects (identified by hashes). | ||
""" | ||
assert len(hash_list) == 1, "Multi-file DFs not supported in HDF5." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arrow?
# Conflicts: # quilt/tools/const.py # quilt/tools/store.py
# Conflicts: # quilt/tools/const.py # quilt/tools/store.py
nl0
pushed a commit
that referenced
this pull request
Dec 7, 2019
nl0
pushed a commit
that referenced
this pull request
Dec 9, 2019
nl0
added a commit
that referenced
this pull request
Dec 9, 2019
* master: Update dependency vega to ^5.9.0 (#34) Update babel monorepo to ^7.7.5 (#31) Update dependency eslint-plugin-redux-saga to ^1.1.3 (#32) Update dependency terser-webpack-plugin to ^1.4.2 (#33) Update dependency @sentry/browser to ^5.10.1 (#27) Update dependency fetch-mock to ^8.0.1 (#28) Update dependency use-debounce to ^3.3.0 (#29) Update dependency react-app-polyfill to ^1.0.5 (#30) Update mui monorepo to ^4.7.1 (#25) Update dependency css-loader to ^3.2.1 (#21) Update dependency use-debounce to ^3.2.0 (#24) Update dependency eslint to ^6.7.2 (#22) Update dependency eslint-plugin-react to ^7.17.0 (#23) Update dependency aws-sdk to ^2.582.0 (#1) Update dependency style-loader to ^1.0.1 Update dependency lint-staged to ^9.5.0 Update dependency coveralls to ^3.0.9 Update dependency connected-react-router to ^6.6.1 Update renovate.json
nl0
added a commit
that referenced
this pull request
Dec 11, 2019
* master: (48 commits) Better package list ux pt. 1: larger hit area (whole tile) (#1439) Fix interrupted downloads causing corrupted manifests (#1438) Fixed missing @ for decorator (#1441) PyPi improvements - VERSION file and CircleCi support for alpha releases (#1427) Fix Telemetry double counting (#1426) preview bio files as plain text (#1435) Link to open data (#1434) Update dependency @material-ui/core to ^4.7.2 (#37) Update dependency @babel/preset-env to ^7.7.6 (#38) Update dependency eslint-import-resolver-webpack to ^0.12.0 (#39) Update dependency vega to ^5.9.0 (#34) Update babel monorepo to ^7.7.5 (#31) Update dependency eslint-plugin-redux-saga to ^1.1.3 (#32) Update dependency terser-webpack-plugin to ^1.4.2 (#33) Update dependency @sentry/browser to ^5.10.1 (#27) Update dependency fetch-mock to ^8.0.1 (#28) Update dependency use-debounce to ^3.3.0 (#29) Update dependency react-app-polyfill to ^1.0.5 (#30) Update mui monorepo to ^4.7.1 (#25) Update dependency css-loader to ^3.2.1 (#21) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a package store class for Parquet packages using the pyarrow library. This also cleans up PackageStore class types by making the package format an Enum.