-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicating "the template" Topology and Market Model when creating a LES #1488
Comments
👍
Does this mean that the user can only choose these templates when starting a new LES? Also, what happens if you clone a LES? Wouldn't you also need to duplicate non-template market models and topologies? |
Yes. And you 'clone' the template (topology or market model) when creating a new LES.
You would duplicate/clone the topologies/market models from the LES in question. Also you can just keep the exact same name, since that doesn't matter that much. As long as you don't use the same names for the templates. |
Wasn't 839 the idea to sort of combine a Market Model and Topology as one whole unit? I can remember this being said in a meeting with @ChaelKruip once. So it could be that it wasn't really speicified in a Github issue or I misunderstood it; could also be 😅 |
I think it is good to become more concrete about what we really want here! 👍 For me the main advantages would be:
|
Goodness no. At least I hope not. I appreciate the scribbles in that issue aren't very clear. 😆 The intention was that we'd have "featured" topologies and market models (or "templates" in this issue) which would be created the same as they are today, on Then when you create a LES you would have the option of cloning one of these templates, or to copy a topology/market model from another LES to which you have access. Your new LES would get a clone of the chosen market model and topology. class TestingGround
- belongs_to :topology
- belongs_to :market_model
+ has_one :topology
+ has_one :market_model
# ...
I think it might be nicer to instead add two new models: For example:
It might be worth exploring whether it still makes sense for |
Hmm.. yes. Interesting thought. I would think it's quiet allright that way. We could also not save the duplicate topology as a new topology in a database table. The things you would edit in the This way - if time let's us - we could expand the graph editor with the technologies table a bit like I once proposed here. |
I'm wondering how we're going to duplicate the topology columns. The first step would be to take a template: {
"name": "HV",
"stakeholder": "aggregator",
"depth": 0,
"x": 0,
"y": 0,
"id": 1,
"children": [
{
"name": "MV1",
"stakeholder": "aggregator",
"depth": 1,
"x": 0,
"y": 100,
"id": 2,
"investment_cost": "",
"technical_lifetime": "",
"capacity": ""
}
]
} Than duplicate it when importing. So create a The next step would be to look at ways to improve the |
What if - when creating a LES - we duplicate the topology and market model. This way the topology and market model will always be unique and belong to one LES. If somebody destroy their LES, they'll destroy the topology and market model (easy as that).
I'd also like to introduce an
template
(boolean) column to indicate that a topology or market model is a template. This would mean that only those 'template' topologies and 'template' market models can be duplicated. This way we can remove clutter in the topology and market model selection while still keeping a unique topology and market model for every created LES.Related #1414, #839
The text was updated successfully, but these errors were encountered: