Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Gen of Owl #72

Merged
merged 80 commits into from
May 17, 2021
Merged

Next Gen of Owl #72

merged 80 commits into from
May 17, 2021

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Mar 30, 2021

This PR contains a bunch of forward-facing changes to Owl:

  • splits up acknowledgement from worker (enabling for long-running jobs)
  • implements a periodical stale-check
  • adds "tenants", used for sharding data across a Redis Cluster
  • internal code quality improvements

@Skn0tt Skn0tt mentioned this pull request Mar 30, 2021
2 tasks
@coveralls
Copy link

coveralls commented Mar 30, 2021

Pull Request Test Coverage Report for Build 728419739

  • 270 of 286 (94.41%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.8%) to 91.412%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/encodeRedisKey.ts 5 6 83.33%
src/redis-commands.ts 13 14 92.86%
src/shared/migrator/migrator.ts 13 14 92.86%
src/worker/job-distributor.ts 53 54 98.15%
src/index.ts 13 16 81.25%
src/shared/acknowledger.ts 40 44 90.91%
src/shared/stale-checker.ts 43 48 89.58%
Totals Coverage Status
Change from base Build 700793021: 2.8%
Covered Lines: 421
Relevant Lines: 443

💛 - Coveralls

@Skn0tt
Copy link
Member Author

Skn0tt commented May 17, 2021

This PR got much too big,
I should merge it real quick!
Better make it work then fast
This PR is a blast

@Skn0tt Skn0tt merged commit 90845d9 into main May 17, 2021
@Skn0tt Skn0tt deleted the next-gen branch May 17, 2021 09:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants