Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up Processing / Ack #32

Closed
wants to merge 32 commits into from
Closed

Split up Processing / Ack #32

wants to merge 32 commits into from

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Feb 14, 2021 •
edited
Loading

This PR splits up processing / acknowledging into two different steps, allowing for longer-running jobs.

  • Fix failing test (something about parallel execution for non-exclusive jobs)
  • Implement staleness detection

@coveralls
Copy link

coveralls commented Mar 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 691220220

  • 121 of 130 (93.08%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 88.571%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/shared/migrator/index.ts 13 14 92.86%
src/index.ts 10 13 76.92%
src/shared/stale-checker.ts 40 45 88.89%
Totals Coverage Status
Change from base Build 677410228: -0.7%
Covered Lines: 339
Relevant Lines: 365
💛 - Coveralls

@Skn0tt Skn0tt marked this pull request as ready for review March 28, 2021 09:51
@Skn0tt
Copy link
Member Author

Skn0tt commented Mar 30, 2021

Closed in favor of #72

@Skn0tt Skn0tt closed this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skn0tt @coveralls