New locale: 'ko' #23

hibiyasleep · 2017-12-26T07:06:52Z

also:

move language files into resources/lang.
added status/action ID on comments.

quisquous

OHMYGOSH! 👍

Thanks for this. I have a few questions for you, but this looks really good overall.

quisquous · 2017-12-26T20:04:40Z

ui/jobs/jobs.html

@@ -12,7 +12,7 @@
  <script src="../../resources/timericon.js"></script>
  <script src="../../resources/widgetlist.js"></script>
  <script src="../../resources/lang.js"></script>
-  <script src="../../resources/lang-en.js"></script>
+  <script src="../../resources/lang/en.js"></script>


Can you include lang/ko.js here as well?

quisquous · 2017-12-26T20:05:57Z

resources/lang/ko.js

+      return Regexes.Parse(' 1E:' + target + ' loses the effect of ' + effect + ' from ' + attacker + '.*\.');
+    };
+
+    this.countdownStartRegex = function() {


Are these the same in Korean? Could you add a "TODO: not translated yet" if not?

Seems only 'gains/loses' and few things are in English, so this doesn't need to translate.

quisquous · 2017-12-26T20:11:19Z

resources/lang/ko.js

+    // We can not look for log messages from FFXIV "You use X" here. Instead we
+    // look for the actual ability usage provided by the XIV plugin.
+    // Also, the networked parse info is given much quicker than the lines from the game.
+    this.youUseAbilityRegex = function() {


I didn't look line by line, but at first glance most of these regex functions look unchanged from the en version. I didn't know at the time whether or not other languages would have the same log messages. Could you move them into the base CactbotLang class so both en and ko can share and not duplicate them?

can Regexes be a method? Since we (yes, Korean) using English version of the plugin, so I can't predict how this should behave on ja/de/fr versions, to always override or not.

Yeah, agreed that I'm not sure ja/de/fr versions will need to do. However, if some derived class needs to override it, they can just override it themselves.

I went ahead and moved these in 30888c4, which hopefully won't cause you too much conflict.

quisquous · 2017-12-26T20:19:37Z

resources/lang/en.js

-      Brotherhood: 'Brotherhood',
-      Devotion: 'Devotion',
-      FoeRequiem: 'Foe Requiem',
+      BluntResistDown: 'Blunt Resistance Down', // 0x23d, 0x335, 0x3a3


I wasn't sure at first what these hex codes meant, but I looked through logs and I think I understand more of the log format. I am very curious about this!

It seems like pairs of :.*0F:(effectId): designate the effect id. Where did all of these values come from? Did you investigate these yourself or is there a list somewhere?

Some of these values, I see in logs, but others I do not. For example, Foe Requiem up I see [15:57:43.750] 15:1067BEA6:Azel Nox:73:Foe Requiem:1067BEA6:Azel Nox:90030F:8B: but I do not see any :8C: for Foe Requiem lost. Similarly, Left Eye and Right Eye are not abilities but only effects, and so I don't know where the values 0x4a0 and 0x49f come from.

Can you help me understand more? I'd love to know. :)

This is internal effect ID and used very widely. also skills, zones has unique ID like this.

0x8C is for enemies. (ps: XIVDB uses the decimal ID to build its URL)

Don't miss out that we can access unparsed log like saved to a .log file, like OverlayPlugin and SpecialSpellTimer do.

Oh, I see! Thanks for the explanation. By not seeing 0x8C, I meant that I didn't see it anywhere in the log, applied to either players or enemies.

I'll have to investigate the unparsed log, thanks for the pointer!

quisquous · 2017-12-26T20:26:06Z

resources/lang/en.js

-      Aetherflow: 'Aetherflow',
-      ChainStrategem: 'Chain Strategem',
-      Hypercharge: 'Hypercharge',
+      DragonKick: 'Dragon Kick', // 0x4a


Were these id comments useful for you when translating? I feel like these ids are all already inside of lang.js and so duplicating them here is a bit noisy. I think I'd prefer to not have them if it was just me, but if they were useful in translating, then I'm happy to leave them.

Translators can reference this ID to query XIVDB (0x8c -> /status/140), or extracted FFXIV data itself.

Oh, it was duplicate, I didn't saw them. I'll remove these comments.

hibiyasleep · 2017-12-27T07:16:38Z

resources/lang/ko.js

+    };
+
+    this.countdownStartRegex = function() {
+      return Regexes.Parse(/Battle commencing in (\y{Float}) seconds!/);


this is TODO, I didn't saw countdown recently.

quisquous

Can you change your upstream branch to be quisquous:master instead of quisquous:localization? I merged localization into master already and had just made a branch for code review purposes.

Once you do that, I think this should be ready to commit.

quisquous · 2017-12-27T21:09:29Z

resources/lang/ko.js

+    // We can not look for log messages from FFXIV "You use X" here. Instead we
+    // look for the actual ability usage provided by the XIV plugin.
+    // Also, the networked parse info is given much quicker than the lines from the game.
+    this.youUseAbilityRegex = function() {


Yeah, agreed that I'm not sure ja/de/fr versions will need to do. However, if some derived class needs to override it, they can just override it themselves.

I went ahead and moved these in 30888c4, which hopefully won't cause you too much conflict.

This doesn't localize jobs yet, but moves all strings and regular expressions out to a separate lang-en.js file. It seems plausible for here to create additiona lang-kr.js and lang-jp.js files if folks want to take on the task of converting all the strings.

hibiyasleep · 2017-12-28T01:25:32Z

I (accidentally) rebased onto upstream/master, there shouldn't be a conflict.

quisquous · 2017-12-28T01:42:48Z

resources/lang.js

-  // We can not look for log messages from FFXIV "You use X" here. Instead we
-  // look for the actual ability usage provided by the XIV plugin.
-  // Also, the networked parse info is given much quicker than the lines from the game.
-  youUseAbilityRegex() {


Can you leave these in CactbotLanguage but remove them from CactbotLanguageEn and CactbotLanguageKo so that they are not duplicated? I think youStartUsingRegex, youGainEffectRegex, youLoseEffectRegex, abilityRegex, gainsEffectRegex, and losesEffectRegex should all be in CactbotLanguage if they are shared. Sorry if I haven't communicated this clearly enough--that was why I moved these functions from CactbotLanguageEn to CactbotLanguage in master.

The countdown regex functions (since they'll be different) can be in CactbotLanguageEn and CactbotLanguageKo.

This is my merging fault, sorry ;( - cherry-picked and amended on 04501a1.

quisquous · 2017-12-28T01:44:38Z

Thanks for your patience with all the back and forth! I really appreciate all the work. :)

Also, should rename all class functions to start with lower case for consistency, but not in this patch to avoid causing conflicts.

quisquous

No worries at all! I just feel guilty going many rounds of comments and wanted to make sure I was being clear. :)

quisquous · 2017-12-28T02:06:26Z

ui/jobs/jobs.js

@@ -360,8 +360,9 @@ function setupBuffTracker() {
      sortKey: 9,
    },
    requiem: {
-      gainRegex: gLang.gainsEffectRegex(gLang.kEffect.FoeRequiem, '(\\y{Name})', '\\1'),
-      loseRegex: gLang.losesEffectRegex(gLang.kEffect.FoeRequiem, '(\\y{Name})', '\\1'),
+      // TODO: Can't use \y{Name} because https://github.com/quisquous/cactbot/issues/22.


I think this is accidental too. Can you revert these three lines?

quisquous · 2017-12-28T06:08:58Z

Thanks! Let me know what I can do to help debug the message issue you're seeing. That really seems like the next issue to getting this working for you.

+ fixed some missingTranslation labels

quisquous reviewed Dec 26, 2017

View reviewed changes

hibiyasleep commented Dec 27, 2017

View reviewed changes

quisquous reviewed Dec 28, 2017

View reviewed changes

hibiyasleep changed the base branch from localization to master December 28, 2017 01:09

quisquous and others added 9 commits December 28, 2017 10:23

Be less greedy in localized regexes

edd9248

Remove unnecessary console.assert define

2b73bb0

move langfile into seperate directory

1aadaad

create ko.js

09fe362

complete ko translations

1c35dde

add id comments to statuses/actions

89b6b00

add some TODO

74150ad

add missing link to lang/ko.js

2f6144d

hibiyasleep force-pushed the locale-ko branch from 08a3da3 to 2f6144d Compare December 28, 2017 01:23

quisquous reviewed Dec 28, 2017

View reviewed changes

Move common function lang functions to base class

04501a1

Also, should rename all class functions to start with lower case for consistency, but not in this patch to avoid causing conflicts.

quisquous reviewed Dec 28, 2017

View reviewed changes

Revert merge mistakes

2959882

quisquous merged commit c2d7e3a into quisquous:master Dec 28, 2017

quisquous mentioned this pull request Feb 19, 2018

Add fr localization #57

Closed

SiliconExarch pushed a commit to SiliconExarch/cactbot that referenced this pull request Jan 5, 2024

i18n: added new translations (quisquous#23)

d362059

+ fixed some missingTranslation labels

SiliconExarch pushed a commit to SiliconExarch/cactbot that referenced this pull request Jan 6, 2024

i18n: added new translations (quisquous#23)

2d920d5

+ fixed some missingTranslation labels

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New locale: 'ko' #23

New locale: 'ko' #23

hibiyasleep commented Dec 26, 2017

quisquous left a comment

quisquous Dec 26, 2017

hibiyasleep Dec 27, 2017

quisquous Dec 26, 2017

hibiyasleep Dec 27, 2017

quisquous Dec 26, 2017

hibiyasleep Dec 27, 2017

quisquous Dec 27, 2017

quisquous Dec 26, 2017

hibiyasleep Dec 27, 2017

hibiyasleep Dec 27, 2017

quisquous Dec 27, 2017

quisquous Dec 26, 2017

hibiyasleep Dec 27, 2017

hibiyasleep Dec 27, 2017

hibiyasleep Dec 27, 2017

quisquous left a comment

quisquous Dec 27, 2017

hibiyasleep commented Dec 28, 2017

quisquous Dec 28, 2017

hibiyasleep Dec 28, 2017

quisquous commented Dec 28, 2017

quisquous left a comment

quisquous Dec 28, 2017

quisquous commented Dec 28, 2017

New locale: 'ko' #23

New locale: 'ko' #23

Conversation

hibiyasleep commented Dec 26, 2017

quisquous left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quisquous left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hibiyasleep commented Dec 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quisquous commented Dec 28, 2017

quisquous left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quisquous commented Dec 28, 2017