-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space bar should be the shortcut for play / pause #1288
Comments
Comment #1 originally posted by s@kazlauskas.me on 2013-11-07T15:14:51.000Z: We have Ctrl+Space bound for that function. |
Comment #2 originally posted by simon.boulier on 2013-11-07T15:31:39.000Z: Yes I know but it is much less practical (especially when the computer is used as "music controller"). |
Comment #3 originally posted by nick.boultbee on 2014-04-25T11:58:27.000Z: It could be configurable... |
Comment #4 originally posted by joschuaga@yahoo.de on 2014-10-07T20:49:43.000Z: I agree, every player I know uses "space" to play / pause. Also, isn't "enter" the key to active the selected (button)? |
Comment #5 originally posted by joschuaga@yahoo.de on 2014-10-07T20:51:38.000Z: I agree, every player I know uses "space" to play / pause. Also, AFAIK normally "enter" is the key to activate the selected button or else. |
The accelerator for
The entry was reset to the default: commented and accelerator set to |
This bug is absolutely infuriating. |
It shouldn't be "configurable", spacebar should be the default play/pause toggle... Also, shouldn't the play button change to the pause button if there is music playing? |
Huh? It already does that. Which version are you using? |
3.5.3., downloaded it in Ubuntu 16.04's software center. Spacebar acts as a play button, not a play/pause toggle. If I manually click the play/pause button, it starts acting as a toggle. If I double click a song, it works as a play button again. So somehow only within the "Play button was last clicked/selected" context does the spacebar act as a toggle. Also it does not change icon. Could it have something to do with me using the Flatabulous theme/Vibrancy Colours Icons theme? |
Oh, okay. You need to upgrade to at least 3.6.0 if you want that:
You could add the PPA from here: http://quodlibet.readthedocs.io/en/latest/downloads.html#ubuntu-logo-ubuntu |
+1 This is maddening. I really can't imagine a workflow where it makes any sense. Like,
As others have mentioned, every single other music/video player in existence works this way. That might not even be an exaggeration. Configurable would be nice, but space bar as a play/pause toggle is the sane default. Can this be fixed via a plugin or other means that don't require directly modifying the source? |
I would like to add to this. The cmd+Spacebar for macOS(osx), is the default for Spotlight/ search. So having it as the 'play' option with no way to change the bindings is the only negative to this wonderful audio player. Otherwise disabling or changing the Spotlight key bindings is not really a solution especially if end user has already become accustom to the cmd+spacebar for all-the-things. |
in #1878 (Support OS-dependent keyboard shortcuts), this comment points out an additional workflow problem:
|
I tend to get frequently bitten by this bug after almost 20 years of using players that bind the space bar the way people are requesting. I really think it makes much more sense to have space as play/pause. Right now it's a minor but relatively frequent pain point for me. |
I stand corrected:
So, contrary to what I said before, commit d4ec970 fixed it. PS: I'm running QL 47e925a on Xubuntu 18.04. |
d4ec970 bound PlayPause to space in the songlist, i.e. it only works when the songlist is in focus. The main issue of having space as a global shortcut (as far as I can see) is that global shortcuts seem to be processed before local key events. So if the shortcut is changed from |
Indeed, I've just confirmed it.
It makes perfect sense ! Shouldn't this issue be closed ? |
No, it should not be closed. If a global shortcut doesn't work, then what could make sense is to add it to every element that could potentially have focus that doesn't need space for its own function - for example, you would bind it to the play list so pressing space in the play list is equivalent to pressing the play/pause button, but not on the transport controls or the search box so you can type spaces in the search box and 'tab' through the transport controls. |
Remember for accessibility Gtk uses tabs & space / enter for moving focus and activating widgets. Whilst I rarely encounter this issue (due to the songlist fix in d4ec970) - I think there are some low hanging fruit as per what @alexforencich said, in particular the info area, and maybe the Cover Art (+ window) |
Original issue 1288 created by simon.boulier on 2013-11-07T11:45:52.000Z:
I would want to change the space bar shortcut so that it toogles play/pause. Don't you? (Currently it activates the selected button).
It seems to me that it's an usual shortcut in other audio players.
Quodlibet is amazing, thank you very much!
Simon
The text was updated successfully, but these errors were encountered: