Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfe: stop playing once queue runs out #43

Closed
lazka opened this issue Mar 14, 2015 · 14 comments
Closed

rfe: stop playing once queue runs out #43

lazka opened this issue Mar 14, 2015 · 14 comments

Comments

@lazka
Copy link
Member

lazka commented Mar 14, 2015

Original issue 43 created by hhaamu on 2008-11-03T18:33:54.000Z:

QL currently has a "Stop after this song" feature hidden beneath the play
button. I'd like it to be duplicated for the queue feature. I often queue
up stuff and wish QL to stop playing after they are played.

Currently, to accomplish this I must either a) clear the playlist or b)
wait for the last song in the queue and use the aforementioned feature.

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #1 originally posted by murman on 2008-11-09T19:46:45.000Z:

<empty>

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #2 originally posted by steven.strobe.cc on 2009-03-24T16:48:06.000Z:

I'd like to see a more general enhancement: clicking on the 'play/pause' column next
to a song changes it to a 'stop' icon, indicating 'stop after this song'. When that
song starts playing, the icon alternates every few seconds between the 'playing' (or
'paused') icon and the 'stop' icon. And, of course, after the song finishes, playback
stops.

This is sane because we've already got the concept of single-click-sensitive columns,
and because other media players use the same method to indicate stop-after, IIRC. If
people like this design I'll make a patch.

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #3 originally posted by eric.potash on 2009-06-16T00:17:35.000Z:

I would definitely be interested in such a patch. I would suggest rethinking the
play/stop alternating icon-- perhaps a play icon with a vertical line after it (see
the attached mockup I made by playing around with the default eject icon).

Side note: whats the difference between right clicking the play button and selecting
"stop after this song" (which is by the way incredibly unintuitive) and selecting the
play order "One Song"?

What would make my day, though, would be an option (perhaps a play order called
"Queue") that stops playing when the queue is done (effectively putting a 'stop after
this song' flag after the last song in the queue, but it would have to move when
stuff is added/removed from the queue so it really does need to be a separate
option). This is the behavior that users of almost any other player expect, and, to
me, it makes at least as much sense as the current behavior.

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #4 originally posted by steven.strobe.cc on 2009-08-25T12:34:50.000Z:

@eric.potash: Please elaborate: how would you want the "Queue" play order to differ
from what "One Song" does now?

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #5 originally posted by jude.venn on 2009-08-25T13:37:11.000Z:

+1 on fixing this - if I'm playing a queue or playlist I don't expect or want the app
to start playing whatever album I happen to be looking at when it finishes.
Currently there's no way I've found of stopping this from happening, without using
"Stop after this Song" while the song is already playing (I want to queue up songs in
advance and know that playback will stop without intervention). Either the Queue
playorder suggested above or even a preference to toggle this auto-album-resume
behaviour would be great.

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #6 originally posted by eric.potash on 2009-08-25T14:26:47.000Z:

@steven: just what jude said. the desired behavior is that when playing from the
queue and the end of the queue is reached, the player should stop completely. "One
song" just stops after the current track.

i'm not sure what it should do if one is playing from the library and not the queue
though. right now if you're playing one album and you browse to another, when the
current song is finished, the first track of the newly selected album starts. this
behavior is, in my mind, very similar to what we are disabling with the Queue play
order so it might make sense to disable them together. i think the behavior as
"autoplay" so maybe if the play order disables both of them it should be called "Manual."

I'm very happy to hear you are thinking about this-- I would really appreciate this
feature!

side question: is there a reason why the queue pane cannot be resized? for me its
stuck at about 4 tracks in height (or hidden).

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #7 originally posted by steven.strobe.cc on 2009-08-25T15:59:04.000Z:

@eric.potash: "One Song" stops after the current song when playing from the SongList,
but if you load the queue and start playing from the queue, it will drain the queue
and stop before playing the next song. (In other words: with the player stopped,
queue some songs and hit "Play" or "Next" (if it's available).) It's pretty much
exactly what I understand you're asking for.

The other option might be "Queue Only", in which double-clicking on anything appends
it to the queue, and the browser doesn't play anything. It might actually be possible
to do it from an Order plugin without touching anything else, I'll test.

RE the queue height: It's disabled in code, but I don't know why. There may be a good
reason for it, but in any case I'll investigate.

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #8 originally posted by steven.strobe.cc on 2009-08-25T16:24:06.000Z:

A Queue Only plugin is in trunk as of revision 42009da.

Turns out it was pretty easy, with one caveat. Double-clicking on any item which
contains multiple songs in it - an album in the album browser, or a filter column in
the paned browser, doesn't do a thing. This would be difficult to fix. But the other
means of adding songs to the queue still work, so that's cool.

If this is the kind of thing you were after, I'll close the issue.

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #9 originally posted by eric.potash on 2009-08-25T16:24:51.000Z:

@steven: yep, you're right. it does produce the desired behavior.

your "queue only" idea is quite nice. (actually its the default behavior of amarok.)
i think it would be a good feature. since it would change the main focus from the
browser to the queue, i think it would be important to make the queue height resizable.

what about the feature you mentioned in comment 2 (stop after this song)?

please let me know if i can test out any patches or plugins you put together. IMO all
of these (related) features could make QL playback much more flexible/dynamic.
thanks for your efforts!

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #10 originally posted by eric.potash on 2009-08-25T16:44:59.000Z:

works. cool! you can close the issue, though double-clicking an album would be very
nice. as would being able to resize the queue pane. and right click -> "stop after
this song." should those be moved into separate issues?

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #11 originally posted by eric.potash on 2009-08-25T16:47:54.000Z:

also, it might make sense to automatically start playing the first track thats added
to the queue?

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #12 originally posted by eric.potash on 2009-08-25T16:49:05.000Z:

i should be more specific: if the queue is empty and the queue only play order is
selected and i double click a track, i'm suggesting it gets added to the queue and
starts to play.

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #13 originally posted by reiter.christoph on 2009-08-26T06:42:42.000Z:

Regarding album/pane clicking: Issue #231 fixes that and I have that 80% finished..
but no time right now.

Nice plugin :)

@lazka
Copy link
Member Author

lazka commented Mar 14, 2015

Comment #14 originally posted by kalvin.rubiksmaster on 2014-03-29T11:54:44.000Z:

Sorry to necrobump this, but from the comment no. 8 about the "Queue Only" plugin, QL's current expected behavior with this plugin enabled is "while queue, dequeue and play next; if queue is empty, cease playback?"

Does this require the browser to be in any particular state? E.g. focused on "All Albums," deliberately cleared of any selection (Ctrl+Shift+A), or is there something else I'm not thinking of?

I have the "Queue Only" plugin enabled. When I tried emptying out my queue, QL played the last song, but proceeded to start the next album highlighted (NOT queued - my queue is dead blank at this point) in the browser. What am I misunderstanding here?

@lazka lazka removed the confirmed label Apr 22, 2015
frestr added a commit to frestr/quodlibet that referenced this issue Mar 20, 2017
declension pushed a commit that referenced this issue Apr 12, 2017
* QueueExpander: Add checkbox to stop player after queue is empty
* QueueExpander: Ensure queue stop is honored when clearing queue
* QueueExpander: Do not explicitly turn off the start_after switch
This is done automatically after each playing song anyway, and
fixes a problem where the switch would be turned off if the
queue was cleared and "Start After Empty" not enabled.
* QueueExpander: Rename 'Stop After Empty' to 'Stop Once Empty'

Fixes #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant