Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keplr link to proposal #102

Closed
hakuno2000 opened this issue Jul 19, 2024 · 2 comments
Closed

Fix Keplr link to proposal #102

hakuno2000 opened this issue Jul 19, 2024 · 2 comments

Comments

@hakuno2000
Copy link
Contributor

I suggest you should change Keplr url format in pkg/types/chain.go like below

	if c.KeplrName != "" {
		links = append(links, Link{
			Name: "Keplr",
			Href: fmt.Sprintf("https://wallet.keplr.app/chains/%s/proposals/%s", c.KeplrName, proposalID),
		})
	}

For example, it should be
https://wallet.keplr.app/chains/injective/proposals/418
instead of
https://wallet.keplr.app/#/injective/governance?detailId=418

@freak12techno
Copy link
Collaborator

Actually yeah, that makes sense. Do you mind making a PR updating it to the correct one?
(I can also do it myself, but I have a bunch of things I should do before that, so it might take some time.

@freak12techno
Copy link
Collaborator

Okay I merged it and pushed v5.14.1 release which should contain it.
Also tested it manually, seems to work correctly.

@hakuno2000 thanks for your contribution!
I'll close this one as resolved, feel free to reopen if you think it's not working correctly, of file a new issue if there's something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants