Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Matrix CS API 0.4.0 #48

Closed
2 tasks done
KitsuneRal opened this issue Sep 1, 2018 · 0 comments
Closed
2 tasks done

Support Matrix CS API 0.4.0 #48

KitsuneRal opened this issue Sep 1, 2018 · 0 comments
Assignees
Labels

Comments

@KitsuneRal
Copy link
Member

KitsuneRal commented Sep 1, 2018

The new release of Matrix CS API has schemas that are compositions of another type and an additional field in the body schema. The following problems should be solved:

  • A combination of $ref and a non-$ref entity under allOf. In the particular cases of CS API it can be remedied by pulling properties of the inner object to the level of the main structure (and that's actually a more transparent description). However, not all (theoretical) cases can be resolved that way, so GTAD has to learn that allOf is allowed to have non-$ref entries.
  • Even if the properties are pulled as described above, GTAD fails to flatten the request body schema, instead creating a type definition that depends on itself (corresponding to struct Type : Type in C++). It should further pull out properties out of the schema and turn them into individual parameters of the request.
@KitsuneRal KitsuneRal added the bug label Sep 1, 2018
@KitsuneRal KitsuneRal self-assigned this Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Version 0.7 - Done
Development

No branches or pull requests

1 participant